From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: David Ahern <dsahern@kernel.org>,
"David S . Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
netdev@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH net v2 1/4] ipv4: fix source address selection with route leak
Date: Mon, 8 Jul 2024 23:27:05 +0200 [thread overview]
Message-ID: <8d993975-e637-4594-8dd8-b725111705e8@6wind.com> (raw)
In-Reply-To: <20240708133233.732e2f0c@kernel.org>
Le 08/07/2024 à 22:32, Jakub Kicinski a écrit :
> On Mon, 8 Jul 2024 20:13:56 +0200 Nicolas Dichtel wrote:
>>> long line length. separate setting the value:
>>>
>>> struct net_device *l3mdev;
>>>
>>> l3mdev = dev_get_by_index_rcu(net, fl4->flowi4_l3mdev);
>> The checkpatch limit is 100-column.
>> If the 80-column limit needs to be enforced in net/, maybe a special case should
>> be added in checkpatch.
>
> That'd be great. I'm pretty unsuccessful to at getting my patches
> accepted to checkpatch and get_maintainers so I gave up.
Oh, ok :/
> But I never tried with the line length limit.
Why not (:
next prev parent reply other threads:[~2024-07-08 21:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240705145302.1717632-1-nicolas.dichtel@6wind.com>
2024-07-05 14:52 ` [PATCH net v2 1/4] ipv4: fix source address selection with route leak Nicolas Dichtel
2024-07-07 16:58 ` David Ahern
2024-07-08 18:13 ` Nicolas Dichtel
2024-07-08 20:32 ` Jakub Kicinski
2024-07-08 21:27 ` Nicolas Dichtel [this message]
2024-07-05 14:52 ` [PATCH net v2 2/4] ipv6: " Nicolas Dichtel
2024-07-07 16:58 ` David Ahern
2024-07-08 18:15 ` Nicolas Dichtel
2024-07-08 18:44 ` David Ahern
2024-07-08 21:24 ` Nicolas Dichtel
2024-07-05 14:52 ` [PATCH net v2 3/4] ipv6: take care of scope when choosing the src addr Nicolas Dichtel
2024-07-07 17:00 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d993975-e637-4594-8dd8-b725111705e8@6wind.com \
--to=nicolas.dichtel@6wind.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox