Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Sasha Levin <sashal@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>,
	"io-uring@vger.kernel.org" <io-uring@vger.kernel.org>,
	Yufan Chen <yufan.chen@linux.dev>,
	dev@rebasedinc.com
Subject: Re: io_uring/eventfd: registered eventfd signals only once after the cd305ee3633a backport (6.18.y, 6.12.y, Ubuntu 26.04)
Date: Thu, 19 Nov 2026 11:10:03 -0700	[thread overview]
Message-ID: <8e8bd832-ead2-4d77-9ca8-48274637d26e@kernel.dk> (raw)
In-Reply-To: <avxPlrd77WiXagvs@laps>

On 11/17/26 5:59 AM, Sasha Levin wrote:
> On Tue, Nov 17, 2026 at 05:45:53AM -0700, Jens Axboe wrote:
>> On 11/17/26 5:42 AM, Sasha Levin wrote:
>>> On Mon, Nov 16, 2026 at 07:21:38PM -0700, Jens Axboe wrote:
>>>> On 11/16/26 2:52 AM, Greg Kroah-Hartman wrote:
>>>>> On Sat, Nov 14, 2026 at 11:12:40AM -0700, Jens Axboe wrote:
>>>>>> On 11/14/26 10:42 AM, Sasha Levin wrote:
>>>>>>> On 2026-11-13, dev@rebasedinc.com wrote:
>>>>>>>> If this is correct, a backport of 04fe9aeb4f3c to 6.18.y and 6.12.y looks like the right fix; it keeps the CVE-2026-80920 fix in place.
>>>>>>>
>>>>>>> Queued for 6.18 and 6.12, thanks.
>>>>>>
>>>>>> Yet another bs CVE - Greg, please invalidate this one too, it's NOT CVE material.
>>>>>> Getting a little tired of chasing these.
>>>>>
>>>>> Now rejected, sorry about that.
>>>>
>>>> Not sure how we improve on that, it's really annoying to catch these bogus
>>>> ones after the fact?
>>>
>>> Hi Jens,
>>>
>>> Since some of our reviews are LLM based, I was looking to see why this one was
>>> flagged as a security issue.
>>>
>>> From the explanation, and looking at the code, it seems that we can register an
>>> eventfd with io_uring, then have epoll watch that same eventfd. When something
>>> wakes the epoll, the kernel is holding epoll's wait-queue lock. That wakeup
>>> runs io_uring's poll handler, which signals the eventfd, but the eventfd is
>>> watched by the same epoll, so it tries to grab that same lock again on the same
>>> CPU. The CPU spins forever on a lock it already holds. One core is dead,
>>> followed by RCU stalls, machine wedges. Any unprivileged user with io_uring
>>> access can do it.
>>
>> I think you're looking at the parent of that, not the followup. Yes the
>> parent is a real fix, it's similar to the eventfd fix in mainline as well
>> for that exact issue.
> 
> If by followup you mean 04fe9aeb4f3c ("io_uring/eventfd: reset deferred signal
> state") then yes, I don't think it's security relevant, and it never had a CVE
> assigned.
> 
> cd305ee3633a ("io_uring: defer eventfd signaling when queued from a wakeup
> handler") is what had the CVE assigned to it, and what Greg rejected earlier.
> Should the rejection be reverted then?

Missed this - I agree with you, I was looking at the wrong commit. FWIW,
this is the same class as:

commit 398e3fa789aa5ffddc8689d8cbc7b31e1824130c
Author: Daehyeon Ko <4ncienth@gmail.com>
Date:   Thu Aug 13 22:38:43 2026 +0900

    aio: prevent eventfd/epoll recursion on poll

but nobody ever assigns CVEs there, apparently? So either both are bogus,
or neither of them are. At least the inconsistencies here are odd and
arbitrary. Since I got curious after having looked at this one which
are basically mirrors of each other, I took a peek at other aio changes
from this year. And they totally back that up - nobody looks at these,
and assigns CVE. Since no development is happening there, commits
touching it are either treewide stuff, or bug fixes. I see 6 bug fixes,
5 of which would fit the bill:

Commit: c03ce4173c7b
Date: Apr 13
Fix: Ring mapping inherited over fork
CVE-worthy? NULL deref in the kernel when the child faults on the ring
after the parent destroys it. Unprivileged. I'd say so, yet no CVE
assigned.

Commit: 3adf7ae18bf4
Date: Apr 18
Fix: Partial mremap of the ring
CVE-worthy? Yes. Same NULL deref, and io_destroy() can unmap unrelated
neighbouring mappings. Unprivileged. Again, no CVE assigned, should have
been.

Commit: 398e3fa789aa
Date: Aug 13
Fix: eventfd/epoll recursion on poll
CVE-worthy? Already mentioned above.

Commit: b44341e39d85
Date: Oct 22
Fix: Request count overflow in ioctx_alloc()
CVE-worthy? Not in my opinion.

Commit: d53b5aa5cfae
Date: Oct 29
Fix: Fault races ring truncation
CVE-worthy? Third route to the same NULL deref, via a killed io_destroy() in a
  task sharing the mm. "Any user can do that" per the commit. Should
have a CVE, yet once again none assigned.

Date: Oct 30
Fix: exit_aio() returns before complete()
CVE-worthy? Ehm write to a freed stack frame, as before unprivileged.
I'd certainly say so.

But apparently nobody looks at aio?!

-- 
Jens Axboe

      reply	other threads:[~2026-11-19 18:10 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-13 23:22 Subject: io_uring/eventfd: registered eventfd signals only once after the cd305ee3633a backport (6.18.y, 6.12.y, Ubuntu 26.04) dev
2026-11-14  2:00 ` Greg KH
2026-11-15  1:13   ` dev
2026-11-14 17:42 ` Sasha Levin
2026-11-14 18:12   ` Jens Axboe
2026-11-16  9:52     ` Greg Kroah-Hartman
2026-11-17  2:21       ` Jens Axboe
2026-11-17  7:42         ` Greg Kroah-Hartman
2026-11-17 12:41           ` Jens Axboe
2026-11-17 12:42         ` Sasha Levin
2026-11-17 12:45           ` Jens Axboe
2026-11-17 12:59             ` Sasha Levin
2026-11-19 18:10               ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8e8bd832-ead2-4d77-9ca8-48274637d26e@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=dev@rebasedinc.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=io-uring@vger.kernel.org \
    --cc=sashal@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=yufan.chen@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox