Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: Matthieu Baerts <matttbe@kernel.org>
To: Qingfang Deng <qingfang.deng@linux.dev>,
	stable@vger.kernel.org, stable-commits@vger.kernel.org
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Shuah Khan <shuah@kernel.org>, Simon Horman <horms@kernel.org>
Subject: Re: Patch "selftests: net: test PPPoE packets in gro.sh" has been added to the 7.1-stable tree
Date: Wed, 29 Jul 2026 10:36:59 +0200	[thread overview]
Message-ID: <8ed53530-ffe6-442f-b386-95b724c22995@kernel.org> (raw)
In-Reply-To: <edf7b946-ca71-4c3f-b942-5e80454d47fe@linux.dev>

Hello,

On 29/07/2026 00:58, Qingfang Deng wrote:
> Hi,
> 
> On 7/29/2026 2:24 AM, Sasha Levin wrote:
>> This is a note to let you know that I've just added the patch titled
>>
>>      selftests: net: test PPPoE packets in gro.sh
>>
>> to the 7.1-stable tree which can be found at:
>>      http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-
>> queue.git;a=summary
>>
>> The filename of the patch is:
>>       selftests-net-test-pppoe-packets-in-gro.sh.patch
>> and it can be found in the queue-7.1 subdirectory.
>>
>> If you, or anyone else, feels it should not be added to the stable tree,
>> please let <stable@vger.kernel.org> know about it.
>>
>>
>>
>> commit f9d9bd13a591537a14c39d0221818180960fc0a3
>> Author: Qingfang Deng <qingfang.deng@linux.dev>
>> Date:   Wed May 13 09:33:49 2026 +0800
>>
>>      selftests: net: test PPPoE packets in gro.sh
>>           [ Upstream commit 6160ec9d03d7af5aa345b8b994de80fa8454274b ]
>>           Add PPPoE test-cases to the GRO selftest. Only run a subset of
>>      common_tests to avoid changing the hardcoded L3 offsets everywhere.
>>      Add a new "pppoe_sid" test case to verify that packets with
>> different
>>      PPPoE session IDs are correctly identified as separate flows and not
>>      coalesced.
>>           Signed-off-by: Qingfang Deng <qingfang.deng@linux.dev>
>>      Link: https://patch.msgid.link/20260513013400.7467-2-
>> qingfang.deng@linux.dev
>>      Signed-off-by: Paolo Abeni <pabeni@redhat.com>
>>      Stable-dep-of: c25dd7439f84 ("selftests: drv-net: add missing
>> kconfig for psp.py")
>>      Signed-off-by: Sasha Levin <sashal@kernel.org>
> 
> Add: Matthieu
> 
> PPPoE GRO is not supported by kernel version 7.1, so this test will
> always fail. Please instead rebase the dep commit.

I guess without this patch, there is a conflict because these two lines
are not in the config file:

 CONFIG_PPP=y
 CONFIG_PPPOE=y

The conflict should be easy to solve, simply by adding ...

 CONFIG_NET_SCH_INGRESS=y

... after

 CONFIG_NET_SCH_FQ=m

Cheers,
Matt

  reply	other threads:[~2026-07-29  8:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20260728182402.314002-1-sashal@kernel.org>
2026-07-28 22:58 ` Patch "selftests: net: test PPPoE packets in gro.sh" has been added to the 7.1-stable tree Qingfang Deng
2026-07-29  8:36   ` Matthieu Baerts [this message]
2026-07-30  2:40   ` Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8ed53530-ffe6-442f-b386-95b724c22995@kernel.org \
    --to=matttbe@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=pabeni@redhat.com \
    --cc=qingfang.deng@linux.dev \
    --cc=shuah@kernel.org \
    --cc=stable-commits@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox