From: "Thomas Weißschuh" <linux@weissschuh.net>
To: Naman Jain <namjain@linux.microsoft.com>
Cc: Michael Kelley <mhklinux@outlook.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
"K . Y . Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Long Li <longli@microsoft.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 6.12] Drivers: hv: Make the sysfs node size for the ring buffer dynamic
Date: Fri, 1 Aug 2025 12:52:15 +0200 [thread overview]
Message-ID: <8f642ca2-04dc-4d87-b120-5d128ec3202e@t-8ch.de> (raw)
In-Reply-To: <4abf15ac-de18-48d4-9420-19d40f26fdd2@linux.microsoft.com>
Hi Naman,
On 2025-07-31 21:13:27+0530, Naman Jain wrote:
> On 7/30/2025 1:15 AM, Michael Kelley wrote:
> > From: Thomas Weißschuh <linux@weissschuh.net> Sent: Tuesday, July 29, 2025 11:47 AM
> > > On 2025-07-29 18:39:45+0000, Michael Kelley wrote:
> > > > From: Naman Jain <namjain@linux.microsoft.com> Sent: Wednesday, July 23, 2025 12:02 AM
<snip>
> > > > Unfortunately, I don't see a fix, short of backporting support for the
> > > > .bin_size function, as this is exactly the problem that function solves.
> > >
> > > It should work out in practice. (I introduced the .bin_size function)
> >
> > The race I describe is unlikely, particularly if attribute groups are created
> > once and then not disturbed. But note that the Hyper-V fcopy group can
> > get updated in a running VM via update_sysfs_group(), which also calls
> > create_files(). Such an update might marginally increase the potential for
> > the race and for getting the wrong size. Still, I agree it should work out
> > in practice.
> >
> > Michael
> >
> > >
> > > Thomas
>
> hi Thomas,
> Would it be possible to port your changes on 6.12 kernel, to avoid such
> race conditions?
Possible, surely. But Greg has to accept it.
And you will need to do the backports.
> Or if it has a lot of dependencies, or if you have a
> follow-up advice, please let us us know.
Not more than mentioned before.
Thomas
next prev parent reply other threads:[~2025-08-01 10:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-23 7:02 [PATCH 6.12] Drivers: hv: Make the sysfs node size for the ring buffer dynamic Naman Jain
2025-07-29 18:39 ` Michael Kelley
2025-07-29 18:46 ` Thomas Weißschuh
2025-07-29 19:45 ` Michael Kelley
2025-07-31 15:43 ` Naman Jain
2025-08-01 10:52 ` Thomas Weißschuh [this message]
2025-08-04 5:49 ` Naman Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f642ca2-04dc-4d87-b120-5d128ec3202e@t-8ch.de \
--to=linux@weissschuh.net \
--cc=decui@microsoft.com \
--cc=gregkh@linuxfoundation.org \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longli@microsoft.com \
--cc=mhklinux@outlook.com \
--cc=namjain@linux.microsoft.com \
--cc=stable@vger.kernel.org \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox