From: Hannes Reinecke <hare@suse.de>
To: Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
linux-scsi@vger.kernel.org
Cc: Sathya.Prakash@broadcom.com,
suganath-prabu.subramani@broadcom.com, stable@vger.kernel.org
Subject: Re: [PATCH] mpt3sas: Use driver scsi lookup to track outstanding IOs
Date: Mon, 25 Feb 2019 18:25:01 +0100 [thread overview]
Message-ID: <8fa0a2ac-dcf7-d4fb-fbfe-0e858fc3c453@suse.de> (raw)
In-Reply-To: <1550577766-40425-1-git-send-email-sreekanth.reddy@broadcom.com>
On 2/19/19 1:02 PM, Sreekanth Reddy wrote:
> Use driver's scsiio lookup table to track outstanding IOs at driver level,
>
> Have done following changes in this patch,
> * Allocated & initialized scsi_lookup table of type
> (struct scsiio_tracker) and of depth host's can_queue at driver load time
> and it will be deallocated at driver unload time.
>
> * Once scmd is receieved, driver will take scsiio_tracker at entry
> corresponding to scmd's tag value from scsi_lookup table. Then this
> scsiio_tracker entry is initialized with proper smid, scmd, cb_idx etc.
> And this scsiio_tracker entry contents are cleared before driver
> calling scsi_done callback function.
>
> * scmd's host_scribble variable is used to save the corresponding
> scsiio_tracker address, later at any time driver can easily retrieve the
> scmd's corresponding scsiio_tacker using this host_scribble variable.
>
> * Whenever driver wants to get the outstanding IOs at the driver level
> then driver can go through this scsi_lookup table and if it observe
> any entry with non-null scmd then it means that scmd is outstanding
> at the driver level.
>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Sreekanth Reddy <sreekanth.reddy@broadcom.com>
> ---
What is the reason for this change?
The description only states _what_ you are doing, not why.
Care to elaborate?
Cheers,
Hannes
next prev parent reply other threads:[~2019-02-25 17:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-19 12:02 [PATCH] mpt3sas: Use driver scsi lookup to track outstanding IOs Sreekanth Reddy
2019-02-19 12:14 ` Greg KH
2019-02-19 13:44 ` Sreekanth Reddy
2019-02-21 4:07 ` Sasha Levin
2019-02-25 17:25 ` Hannes Reinecke [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-02-19 12:00 Sreekanth Reddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8fa0a2ac-dcf7-d4fb-fbfe-0e858fc3c453@suse.de \
--to=hare@suse.de \
--cc=Sathya.Prakash@broadcom.com \
--cc=linux-scsi@vger.kernel.org \
--cc=sreekanth.reddy@broadcom.com \
--cc=stable@vger.kernel.org \
--cc=suganath-prabu.subramani@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox