From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Sean Anderson <sean.anderson@seco.com>,
Dan Carpenter <dan.carpenter@linaro.org>,
Joy Chakraborty <joychakr@google.com>,
linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH v2] rtc: abx80x: Fix return value of nvmem callback on read
Date: Fri, 21 Jun 2024 22:21:45 +0100 [thread overview]
Message-ID: <91d242ae-ece2-4665-ac1e-54694152da70@linaro.org> (raw)
In-Reply-To: <202406211503118dfe2df1@mail.local>
On 21/06/2024 16:03, Alexandre Belloni wrote:
> On 21/06/2024 07:23:24+0100, Srinivas Kandagatla wrote:
>>
>> On Thu, 13 Jun 2024 12:07:50 +0000, Joy Chakraborty wrote:
>>> Read callbacks registered with nvmem core expect 0 to be returned on
>>> success and a negative value to be returned on failure.
>>>
>>> abx80x_nvmem_xfer() on read calls i2c_smbus_read_i2c_block_data() which
>>> returns the number of bytes read on success as per its api description,
>>> this return value is handled as an error and returned to nvmem even on
>>> success.
>>>
>>> [...]
>>
>> Applied, thanks!
>>
>> [1/1] rtc: abx80x: Fix return value of nvmem callback on read
>> commit: 126b2b4ec0f471d46117ca31b99cd76b1eee48d8
>>
>
> Please drop it from your tree, I'm going to handle the rtc related
> patches...
>
Sure I will drop it.
--srini
>> Best regards,
>> --
>> Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>>
>
next prev parent reply other threads:[~2024-06-21 21:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-13 12:07 [PATCH v2] rtc: abx80x: Fix return value of nvmem callback on read Joy Chakraborty
2024-06-13 12:31 ` Dan Carpenter
2024-06-13 15:11 ` Sean Anderson
2024-06-21 6:23 ` Srinivas Kandagatla
2024-06-21 15:03 ` Alexandre Belloni
2024-06-21 21:21 ` Srinivas Kandagatla [this message]
2024-06-27 22:22 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91d242ae-ece2-4665-ac1e-54694152da70@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=alexandre.belloni@bootlin.com \
--cc=dan.carpenter@linaro.org \
--cc=joychakr@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=sean.anderson@seco.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox