From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51566C0015E for ; Mon, 17 Jul 2023 13:04:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231184AbjGQNEp (ORCPT ); Mon, 17 Jul 2023 09:04:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46884 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231350AbjGQNEo (ORCPT ); Mon, 17 Jul 2023 09:04:44 -0400 Received: from smtp-fw-9102.amazon.com (smtp-fw-9102.amazon.com [207.171.184.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 97C2C10DF for ; Mon, 17 Jul 2023 06:04:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1689599079; x=1721135079; h=message-id:date:mime-version:from:subject:to:cc: content-transfer-encoding; bh=eYMzENw1BTuo/ap4guaRZMXoY3mb4hmIJZ9OwVdL9PI=; b=YmwQyBK78kf2f2jUr9k53UzZ8197BnZy2apaRuFlXEe5Hnl2nM6kvH8v u9sVZG6CJkfdoBTDLLLhhYrL5yaiV6stsBXfgIV5Iaj5B5sHPVJz25THo OhQDl2/fA/MMofXE6AYwfrnb1vrFxp0DWJq+sfiHW1sOLQBsfERqe6mTF Y=; X-IronPort-AV: E=Sophos;i="6.01,211,1684800000"; d="scan'208";a="351882009" Received: from pdx4-co-svc-p1-lb2-vlan2.amazon.com (HELO email-inbound-relay-iad-1a-m6i4x-54a853e6.us-east-1.amazon.com) ([10.25.36.210]) by smtp-border-fw-9102.sea19.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jul 2023 13:04:33 +0000 Received: from EX19MTAUEC002.ant.amazon.com (iad12-ws-svc-p26-lb9-vlan3.iad.amazon.com [10.40.163.38]) by email-inbound-relay-iad-1a-m6i4x-54a853e6.us-east-1.amazon.com (Postfix) with ESMTPS id 5012246BA0; Mon, 17 Jul 2023 13:04:31 +0000 (UTC) Received: from EX19D028UEC003.ant.amazon.com (10.252.137.159) by EX19MTAUEC002.ant.amazon.com (10.252.135.253) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.30; Mon, 17 Jul 2023 13:04:30 +0000 Received: from [10.136.59.42] (10.136.59.42) by EX19D028UEC003.ant.amazon.com (10.252.137.159) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.30; Mon, 17 Jul 2023 13:04:28 +0000 Message-ID: <935c4751-d368-df29-33a6-9f4fcae720fa@amazon.com> Date: Mon, 17 Jul 2023 09:04:26 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Content-Language: en-US From: Luiz Capitulino Subject: [5.10, 5.15] New bpf kselftest failure To: Greg KH , "sashal@kernel.org" , CC: "stable@vger.kernel.org" , , Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.136.59.42] X-ClientProxiedBy: EX19D040UWB004.ant.amazon.com (10.13.138.91) To EX19D028UEC003.ant.amazon.com (10.252.137.159) Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Hi, The upstream commit below is backported to 5.10.186, 5.15.120 and 6.1.36: """ commit ecdf985d7615356b78241fdb159c091830ed0380 Author: Eduard Zingerman Date: Wed Feb 15 01:20:27 2023 +0200 bpf: track immediate values written to stack by BPF_ST instruction """ This commit is causing the following bpf:test_verifier kselftest to fail: """ # #760/p precise: ST insn causing spi > allocated_stack FAIL """ Since this test didn't fail before ecdf985d76 backport, the question is if this is a test bug or if this commit introduced a regression. I haven't checked if this failure is present in latest Linus tree because I was unable to build & run the bpf kselftests in an older distro. Also, there some important details about running the bpf kselftests in 5.10 and 5.15: * On 5.10, bpf kselftest build is broken. The following upstream commit needs to be cherry-picked for it to build & run: """ commit 4237e9f4a96228ccc8a7abe5e4b30834323cd353 Author: Gilad Reti Date: Wed Jan 13 07:38:08 2021 +0200 selftests/bpf: Add verifier test for PTR_TO_MEM spill """ * On 5.15.120 there's one additional test that's failing, but I didn't debug this one: """ #150/p calls: trigger reg2btf_ids[reg→type] for reg→type > __BPF_REG_TYPE_MAX FAIL FAIL """ * On 5.11 onwards, building and running bpf tests is disabled by default by commit 7a6eb7c34a78498742b5f82543b7a68c1c443329, so I wonder if we want to backport this to 5.10 as well? Thanks! - Luiz