Re: [PATCH v3] netfs: fix reference leak

[David Howells <dhowells@redhat.com>]

David Howells <dhowells@redhat.com> wrote:

> +/*
> + * Free a request (synchronously) that was just allocated but has
> + * failed before it could be submitted.
> + */
> +void netfs_put_failed_request(struct netfs_io_request *rreq)
> +{
> +	/* new requests have two references (see
> +	 * netfs_alloc_request(), and this function is only allowed on
> +	 * new request objects
> +	 */
> +	WARN_ON_ONCE(refcount_read(&rreq->ref) != 2);
> +
> +	trace_netfs_rreq_ref(rreq->debug_id, 0, netfs_rreq_trace_put_failed);
> +	netfs_free_request(&rreq->cleanup_work);
> +}
> +

Sigh.  I forgot to commit my changes.  Will repost.

David