From: "Aiqun(Maria) Yu" <quic_aiquny@quicinc.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: <linux-gpio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<kernel@quicinc.com>, <stable@vger.kernel.org>
Subject: Re: [PATCH] pinctrl: avoid reload of p state in interation
Date: Wed, 15 Nov 2023 08:56:35 +0800 [thread overview]
Message-ID: <94de6d83-d181-4a04-875a-377fb5e10b25@quicinc.com> (raw)
In-Reply-To: <CACRpkdYgyASV6ttW=AeAWSh3oiFDk9_Q1WV00=7yTxtuhpdXEg@mail.gmail.com>
On 11/14/2023 9:21 PM, Linus Walleij wrote:
> Hi Maria,
>
> thanks for your patch!
>
> On Tue, Nov 14, 2023 at 9:54 AM Maria Yu <quic_aiquny@quicinc.com> wrote:
>
>> When in the list_for_each_entry interation, reload of p->state->settings
>> with a local setting from old_state will makes the list interation in a
>> infite loop.
>>
>> Signed-off-by: Maria Yu <quic_aiquny@quicinc.com>
>
> This makes sense in a way, since this is a compiler-dependent problem,
> can you state in the commit message which compiler and architecture
> you see this on?
I have a crash dump which caused by this issue which is using Clang
10.0, arm64, Linux Version 4.19.
Thx for your suggestion, I will put this information in the commit message.
>
> If it is a regression, should this also be queued for stable? (I guess so?)
This is a corner case which is very hard to reproduce in product, I
suggest this fix to be queued for stable.
>
> Yours,
> Linus Walleij
--
Thx and BRs,
Aiqun(Maria) Yu
next prev parent reply other threads:[~2023-11-15 0:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-14 8:52 [PATCH] pinctrl: avoid reload of p state in interation Maria Yu
2023-11-14 8:56 ` kernel test robot
2023-11-14 13:21 ` Linus Walleij
2023-11-15 0:56 ` Aiqun(Maria) Yu [this message]
2023-11-15 2:07 ` andy.shevchenko
2023-11-15 3:05 ` Aiqun(Maria) Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94de6d83-d181-4a04-875a-377fb5e10b25@quicinc.com \
--to=quic_aiquny@quicinc.com \
--cc=kernel@quicinc.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox