From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-175.mta1.migadu.com (out-175.mta1.migadu.com [95.215.58.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B040A55784 for ; Tue, 27 Feb 2024 09:04:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709024694; cv=none; b=HnVmtpYtzN+kzzSvj8WqpslyX5vgF9CBrlBHISURDh30qlTpvu56jL2VrYsUE1eMeWXRrJNyHJKqQnsJEmv2q/f1Cm1j2ZpApQDzcO8KlnNTJPhAXy2ur9CZwglQkC1E3xlW3TlKMzZWJrfKjfYmgCNCsb4m2GsOoz7yxlGkYHg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709024694; c=relaxed/simple; bh=A7evPsmgZ44m271mYe+qFRKf60yaTpcqyxQbwIVrIMc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PNpNaz2SqM+TBQhlOPFefvhWnooxUd6ZHbtU4UtZC09MIEUoOeZqpESYG8J2lO2W5BsOXn+2BdfMcGRcvUjf+FxwE5xOPLyIRQGG+EieUErCsUOmriZhkENEvLG1ur1v/rRUDIpJ8c1qMk0kl7NGU9qz2lsSgcint55ZwjURDNo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=rzrny31z; arc=none smtp.client-ip=95.215.58.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="rzrny31z" Message-ID: <95333296-d656-4982-bec0-aee2d54ba254@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1709024689; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=H7/84TzBF+jT35enfzQ7YOwiSBEUyInd/LOLc13rNuY=; b=rzrny31z0/va5av7aj4IxvhsNPqhTFJeHINjDoXq99ZmH+cLC/MNas3W+ltzMMw9JBk8V+ E7bAM3I/QfzzpsKlRT9dC6EFoFvVEKBJ13PUXWv7/2J/Un/19wNsD4mEMANaJq71Kh0hK+ /ZWJIZc4ZWgXxDoIKOGd63kwAWWbBEw= Date: Tue, 27 Feb 2024 17:04:19 +0800 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH] mm/zswap: invalidate duplicate entry when !zswap_enabled Content-Language: en-US To: Greg KH Cc: stable@vger.kernel.org, Chengming Zhou , Johannes Weiner , Nhat Pham , Yosry Ahmed , Andrew Morton References: <2024022622-agony-salvaging-5082@gregkh> <20240227022654.3442054-1-chengming.zhou@linux.dev> <2024022743-rented-trembling-7797@gregkh> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Chengming Zhou In-Reply-To: <2024022743-rented-trembling-7797@gregkh> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 2024/2/27 16:54, Greg KH wrote: > On Tue, Feb 27, 2024 at 02:26:54AM +0000, chengming.zhou@linux.dev wrote: >> From: Chengming Zhou >> >> We have to invalidate any duplicate entry even when !zswap_enabled since >> zswap can be disabled anytime. If the folio store success before, then >> got dirtied again but zswap disabled, we won't invalidate the old >> duplicate entry in the zswap_store(). So later lru writeback may >> overwrite the new data in swapfile. >> >> Link: https://lkml.kernel.org/r/20240208023254.3873823-1-chengming.zhou@linux.dev >> Fixes: 42c06a0e8ebe ("mm: kill frontswap") >> Signed-off-by: Chengming Zhou >> Acked-by: Johannes Weiner >> Cc: Nhat Pham >> Cc: Yosry Ahmed >> Cc: >> Signed-off-by: Andrew Morton >> (cherry picked from commit 678e54d4bb9a4822f8ae99690ac131c5d490cdb1) > > What tree is this for? Ah, for linux-6.7.y. I forgot to use your command line to send patch... Thanks.