From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:37893 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751450AbcEZQvK (ORCPT ); Thu, 26 May 2016 12:51:10 -0400 Subject: Re: [PATCH] KVM: x86: mask CPUID(0xD,0x1).EAX against host value To: Greg KH References: <1464263046-40005-1-git-send-email-pbonzini@redhat.com> <20160526163626.GB13099@kroah.com> Cc: stable@vger.kernel.org, rkrcmar@redhat.com From: Paolo Bonzini Message-ID: <95bc9f30-ddf4-267c-9b74-c644c1101cac@redhat.com> Date: Thu, 26 May 2016 18:51:03 +0200 MIME-Version: 1.0 In-Reply-To: <20160526163626.GB13099@kroah.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: On 26/05/2016 18:36, Greg KH wrote: > On Thu, May 26, 2016 at 01:44:06PM +0200, Paolo Bonzini wrote: >> commit 316314cae15fb0e3869b76b468f59a0c83ac3d4e upstream. >> >> This ensures that the guest doesn't see XSAVE extensions >> (e.g. xgetbv1 or xsavec) that the host lacks. >> >> Cc: stable@vger.kernel.org >> Reviewed-by: Radim Krčmář >> Signed-off-by: Paolo Bonzini >> >> Conflicts: >> arch/x86/kvm/cpuid.c > > Why is this here? It's why the patch couldn't be lifted straight from Linus's tree. "git cherry-pick" places it here. Granted, this time it doesn't add much information since the patch touched one file only. >> >> [4.5 does have CPUID_D_1_EAX, but earlier kernels don't, so use >> the numeric value. This is consistent with other occurrences >> of cpuid_mask in arch/x86/kvm/cpuid.c - Paolo] > > What stable tree(s) do you want this applied to? All where it applies. Paolo