From: Pavel Begunkov <asml.silence@gmail.com>
To: Jens Axboe <axboe@kernel.dk>, Palash Oswal <hello@oswalpalash.com>
Cc: dvyukov@google.com, io-uring@vger.kernel.org,
linux-kernel@vger.kernel.org, oswalpalash@gmail.com,
syzbot+be51ca5a4d97f017cd50@syzkaller.appspotmail.com,
syzkaller-bugs@googlegroups.com, stable@vger.kernel.org
Subject: Re: [PATCH 5.13] io_uring: Check current->io_uring in io_uring_cancel_sqpoll
Date: Tue, 27 Apr 2021 18:04:11 +0100 [thread overview]
Message-ID: <964956e9-e75a-257c-ac9e-4365b2be0020@gmail.com> (raw)
In-Reply-To: <de97e0f0-1c47-1a96-eb24-e62c37d2a06b@kernel.dk>
On 4/27/21 6:00 PM, Jens Axboe wrote:
> On 4/27/21 11:00 AM, Pavel Begunkov wrote:
>> On 4/27/21 2:37 PM, Jens Axboe wrote:
>>> On 4/27/21 6:51 AM, Palash Oswal wrote:
>>>> syzkaller identified KASAN: null-ptr-deref Write in
>>>> io_uring_cancel_sqpoll on v5.12
>>>>
>>>> io_uring_cancel_sqpoll is called by io_sq_thread before calling
>>>> io_uring_alloc_task_context. This leads to current->io_uring being
>>>> NULL. io_uring_cancel_sqpoll should not have to deal with threads
>>>> where current->io_uring is NULL.
>>>>
>>>> In order to cast a wider safety net, perform input sanitisation
>>>> directly in io_uring_cancel_sqpoll and return for NULL value of
>>>> current->io_uring.
>>>
>>> Thanks applied - I augmented the commit message a bit.
>>
>> btw, does it fixes the replied before syz report? Should
>> syz fix or tag it if so.
>> Reported-by: syzbot+be51ca5a4d97f017cd50@syzkaller.appspotmail.com
>
> That tag was already there.
Oh, right, missed it
--
Pavel Begunkov
prev parent reply other threads:[~2021-04-27 17:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <e67b2f55-dd0a-1e1f-e34b-87e8613cd701@gmail.com>
2021-04-27 12:51 ` [PATCH 5.13] io_uring: Check current->io_uring in io_uring_cancel_sqpoll Palash Oswal
2021-04-27 13:08 ` Pavel Begunkov
2021-04-27 13:37 ` Jens Axboe
2021-04-27 17:00 ` Pavel Begunkov
2021-04-27 17:00 ` Jens Axboe
2021-04-27 17:04 ` Pavel Begunkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=964956e9-e75a-257c-ac9e-4365b2be0020@gmail.com \
--to=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=dvyukov@google.com \
--cc=hello@oswalpalash.com \
--cc=io-uring@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oswalpalash@gmail.com \
--cc=stable@vger.kernel.org \
--cc=syzbot+be51ca5a4d97f017cd50@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox