Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: Luiz Capitulino <luizcap@amazon.com>
To: "stable@vger.kernel.org" <stable@vger.kernel.org>,
	Greg KH <gregkh@linuxfoundation.org>,
	"sashal@kernel.org" <sashal@kernel.org>
Cc: <42.hyeyoo@gmail.com>
Subject: [6.1] Please apply cc6003916ed46d7a67d91ee32de0f9138047d55f
Date: Thu, 19 Oct 2023 21:27:37 -0400	[thread overview]
Message-ID: <97397e8d-f447-4cf7-84a1-070989d0a7fd@amazon.com> (raw)

Hi,

As reported before[1], we found another regression in 6.1 when doing
performance comparisons with 5.10. This one is caused by CONFIG_DEBUG_PREEMPT
being enabled by default by the following upstream commit if you have the
right config dependencies enabled (commit is introduced in v5.16-rc1):

"""
commit c597bfddc9e9e8a63817252b67c3ca0e544ace26
Author: Frederic Weisbecker <frederic@kernel.org>
Date: Tue Sep 14 12:31:34 2021 +0200

sched: Provide Kconfig support for default dynamic preempt mode
"""

We found up to 8% performance improvement with CONFIG_DEBUG_PREEMPT
disabled in different perf benchmarks (including UnixBench process
creation and redis). The root cause is explained in the commit log
below which is merged in 6.3 and applies (almost) clealy on 6.1.59.

"""
commit cc6003916ed46d7a67d91ee32de0f9138047d55f
Author: Hyeonggon Yoo <42.hyeyoo@gmail.com>
Date:   Sat Jan 21 12:39:42 2023 +0900

     lib/Kconfig.debug: do not enable DEBUG_PREEMPT by default

     In workloads where this_cpu operations are frequently performed,
     enabling DEBUG_PREEMPT may result in significant increase in
     runtime overhead due to frequent invocation of
     __this_cpu_preempt_check() function.

     This can be demonstrated through benchmarks such as hackbench where this
     configuration results in a 10% reduction in performance, primarily due to
     the added overhead within memcg charging path.
"""

[1] https://lore.kernel.org/stable/010edf5a-453d-4c98-9c07-12e75d3f983c@amazon.com/

             reply	other threads:[~2023-10-20  1:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-20  1:27 Luiz Capitulino [this message]
2023-10-20  2:46 ` [6.1] Please apply cc6003916ed46d7a67d91ee32de0f9138047d55f Hyeonggon Yoo
2023-10-20  6:11   ` Greg KH
2023-10-20 13:49   ` Luiz Capitulino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=97397e8d-f447-4cf7-84a1-070989d0a7fd@amazon.com \
    --to=luizcap@amazon.com \
    --cc=42.hyeyoo@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=sashal@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox