From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout.easymail.ca ([64.68.200.34]:45063 "EHLO mailout.easymail.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726468AbeJIDUC (ORCPT ); Mon, 8 Oct 2018 23:20:02 -0400 Subject: Re: [PATCH] usbip: vhci_hcd: check port number before using To: Sudip Mukherjee Cc: Valentina Manea , Greg Kroah-Hartman , linux-kernel , linux-usb@vger.kernel.org, syzbot+600b03e0cf1b73bb23c4@syzkaller.appspotmail.com, Stable , Shuah Khan References: <20181008191913.11527-1-sudip.mukherjee@codethink.co.uk> From: Shuah Khan Message-ID: <97565b6e-025a-520e-d1c9-8f47b1934153@kernel.org> Date: Mon, 8 Oct 2018 14:06:23 -0600 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: On 10/08/2018 02:01 PM, Sudip Mukherjee wrote: > On Mon, Oct 8, 2018 at 8:29 PM Shuah Khan wrote: >> >> Hi Sudip, >> >> On 10/08/2018 01:19 PM, Sudip Mukherjee wrote: >>> From: Sudip Mukherjee >>> >>> The port number is checked and it just prints an error message but it >>> still continues to use the invalid port. And as a result it accesses >>> memory which is not its resulting in BUG report from KASAN. >> >> Yes there is an issue with out of bounds access. But this isn't the >> right fix. >> >>> >>> Reported-by: syzbot+600b03e0cf1b73bb23c4@syzkaller.appspotmail.com >>> Cc: stable >>> Signed-off-by: Sudip Mukherjee >> >> I sent in a fix for this last Friday. >> >> https://patchwork.kernel.org/patch/10628833/ > > And I can confirm this patch also fixes the issue tested with the > reproducer I was using in my vm. > > Great Thanks for testing the patch. thanks, -- Shuah