public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Lu Baolu <baolu.lu@linux.intel.com>
To: Adrian Huang <adrianhuang0701@gmail.com>,
	David Woodhouse <dwmw2@infradead.org>
Cc: baolu.lu@linux.intel.com, Joerg Roedel <joro@8bytes.org>,
	iommu@lists.linux-foundation.org,
	Kevin Tian <kevin.tian@intel.com>, Liu Yi L <yi.l.liu@intel.com>,
	Jacob Pan <jacob.jun.pan@linux.intel.com>,
	Nirmal Patel <nirmal.patel@linux.intel.com>,
	Jonathan Derrick <jonathan.derrick@linux.dev>,
	stable@vger.kernel.org, Adrian Huang <ahuang12@lenovo.com>
Subject: Re: [PATCH v2 1/1] iommu/vt-d: Fix list_add double add when enabling VMD and scalable mode
Date: Fri, 18 Feb 2022 10:29:06 +0800	[thread overview]
Message-ID: <989cf124-13d7-5601-a942-e515c81a72a9@linux.intel.com> (raw)
In-Reply-To: <20220216091307.703-1-adrianhuang0701@gmail.com>

On 2/16/22 5:13 PM, Adrian Huang wrote:
> pci_real_dma_dev() in pci_for_each_dma_alias() gets the real dma device
> which is the VMD device 0000:59:00.5. However, pte of the VMD device
> 0000:59:00.5 has been configured during this message "pci 0000:59:00.5:
> Adding to iommu group 42". So, the status -EBUSY is returned when
> configuring pasid entry for device 10000:80:01.0.

So the VMD subdevice (pci 10000:80:01.0) is an alias device of the "pci
0000:59:00.5", and it uses the Source-ID of "pci 0000:59:00.5" for DMA
transactions. Do I understand it right? If so, it makes sense to skip
setting up pasid entry for VMD subdevices.

Another thing I am still concerned is about the context entry setup.
What does the context entries look like for both VMD and subdevices
after domain_context_mapping() being called?

Best regards,
baolu

  reply	other threads:[~2022-02-18  2:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-16  9:13 [PATCH v2 1/1] iommu/vt-d: Fix list_add double add when enabling VMD and scalable mode Adrian Huang
2022-02-18  2:29 ` Lu Baolu [this message]
2022-02-18  8:21   ` Huang Adrian
2022-02-21  2:44     ` Lu Baolu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=989cf124-13d7-5601-a942-e515c81a72a9@linux.intel.com \
    --to=baolu.lu@linux.intel.com \
    --cc=adrianhuang0701@gmail.com \
    --cc=ahuang12@lenovo.com \
    --cc=dwmw2@infradead.org \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jacob.jun.pan@linux.intel.com \
    --cc=jonathan.derrick@linux.dev \
    --cc=joro@8bytes.org \
    --cc=kevin.tian@intel.com \
    --cc=nirmal.patel@linux.intel.com \
    --cc=stable@vger.kernel.org \
    --cc=yi.l.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox