From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f179.google.com ([209.85.192.179]:33827 "EHLO mail-pf0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755757AbeDZLku (ORCPT ); Thu, 26 Apr 2018 07:40:50 -0400 Subject: Re: [PATCH] USB: serial: option: adding support for ublox R410M From: Lars Melin To: =?UTF-8?Q?Bj=c3=b8rn_Mork?= , Johan Hovold Cc: =?UTF-8?B?U1ogTGluICjmnpfkuIrmmbop?= , stable , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Dan Williams References: <20180426062831.320-1-sz.lin@moxa.com> <20180426070927.GT4615@localhost> <72c63853-aa2d-e74c-1112-36d54ef52a85@gmail.com> <20180426081403.GA335@localhost> <87r2n25i6i.fsf@miraculix.mork.no> <3895ed90-bbb9-e7ce-34c0-a1654646cf83@gmail.com> Message-ID: <98b50ae7-b889-6811-476e-9cdc8a62a484@gmail.com> Date: Thu, 26 Apr 2018 18:40:46 +0700 MIME-Version: 1.0 In-Reply-To: <3895ed90-bbb9-e7ce-34c0-a1654646cf83@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: On 4/26/2018 18:39, Lars Melin wrote: > On 4/26/2018 18:19, Bjørn Mork wrote: >> Anyway, Qualcomm based designs are definitely handled by both drivers. >> Using qcserial only makes sense if the interface layout matches one of >> the defined shared schemes, which currently are: >> >>     QCSERIAL_G2K = 0,    /* Gobi 2000 */ >>     QCSERIAL_G1K = 1,    /* Gobi 1000 */ >>     QCSERIAL_SWI = 2,    /* Sierra Wireless */ >>     QCSERIAL_HWI = 3,    /* Huawei */ > > It seems to me that this Quectel device matches the interface layout for > Gobi1K: > >          * Gobi 1K USB layout: >          * 0: DM/DIAG (use libqcdm from ModemManager for communication) >          * 1: serial port (doesn't respond) >          * 2: AT-capable modem port >          * 3: QMI/net >          */ > > /Lars Ublox, not Quectel..