From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl0-f47.google.com ([209.85.160.47]:46126 "EHLO mail-pl0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751019AbeBJRhp (ORCPT ); Sat, 10 Feb 2018 12:37:45 -0500 Received: by mail-pl0-f47.google.com with SMTP id 36so2924379ple.13 for ; Sat, 10 Feb 2018 09:37:45 -0800 (PST) Subject: Re: sched/wait: Fix add_wait_queue() behavioral change To: Tetsuo Handa , osandov@fb.com, stable@vger.kernel.org Cc: peterz@infradead.org, torvalds@linux-foundation.org, tglx@linutronix.de, kernel-team@fb.com, mingo@kernel.org References: <201802102314.AGJ39032.LMFJFtOSOQFVOH@I-love.SAKURA.ne.jp> From: Jens Axboe Message-ID: <9a183b1a-e6e2-bed1-4816-694b54594cbc@kernel.dk> Date: Sat, 10 Feb 2018 10:37:42 -0700 MIME-Version: 1.0 In-Reply-To: <201802102314.AGJ39032.LMFJFtOSOQFVOH@I-love.SAKURA.ne.jp> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: On 2/10/18 7:14 AM, Tetsuo Handa wrote: > Recently, we are seeing I/O hungup reports. > > I don't know whether a regression introduced by commit 50816c48997af857 > ("sched/wait: Standardize internal naming of wait-queue entries") is relevant. > But shouldn't we backport commit c6b9d9a330290144 ("sched/wait: Fix > add_wait_queue() behavioral change") to 4.13+ kernels anyway? Yes, it most certainly should! -- Jens Axboe