From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 797DF3ACF18 for ; Tue, 24 Mar 2026 10:39:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.13 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774348760; cv=none; b=FRK7ClrcG2xU0/SdoDaSOvbueSTReQLfXgn5hdBoIw2Izg7+/uc/CVFdXb+yuWoNNGq+URbK4gBTJqZ0z6Ng5ZlubVlR72iC8AHwTM/VX92ki+Pj3CniNHfUyIH5Hm8a1KPqf00RvznqcFuSYkemHGc6dYeanInGlKBwimRbYNw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774348760; c=relaxed/simple; bh=MrpHzRQwsA0FTen4mArLVyDHGZDKD5kjPbvGmciIpHI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Gx8ad+qcfMaJq3l8xL9vzhSTA+IrR6k1Oy1jr/0p9lLFa6rS2QPfrDOK8sEJSTqjXwXCD09BfFpYNf/lo2/GyuOoMYDv4XGhXbHlzUxitbbEzyYD/vk4+zjpAWca02A8YxZy+vNdS7la8tq0339EIZ0qDlecLO/x9d9nUGlZmk8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=jMJa+if1; arc=none smtp.client-ip=198.175.65.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="jMJa+if1" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1774348758; x=1805884758; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=MrpHzRQwsA0FTen4mArLVyDHGZDKD5kjPbvGmciIpHI=; b=jMJa+if1LbQ8+E8Hxy45uNK8emHg0d1vCgW5YboOzgHuESTwafGXW0KD FhcqZct3DVbat3MxEdM+/XUegt/7jdiWMFt3aKKKfpuMm4i7Dz7onvJOR nxHSDnfRXyIbZ3ScZd0qS2StAkMnDVdYB0LNSBwQs/u0gtL/qAmeB3F03 Bv/6NlfceeW9njiGAMoDXDTYCnN7wdTPjwtZ6666dLK/mt0prMTegLJEm saLy5qT5WdjjXURi2rXGcVBYHUyFZ5KUvRlV+gpNqjTpBRmoWwik6nHr2 mZvr9kO1fo7W0CFP6CgDPgjIifNmOVvuOEka4FVTgo8RffCMLHwLZr8cB w==; X-CSE-ConnectionGUID: oJoEFb/oStK7t57TfxT3hw== X-CSE-MsgGUID: MEZPZS/jTKGhSDi5sXclbw== X-IronPort-AV: E=McAfee;i="6800,10657,11738"; a="86434707" X-IronPort-AV: E=Sophos;i="6.23,138,1770624000"; d="scan'208";a="86434707" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Mar 2026 03:39:16 -0700 X-CSE-ConnectionGUID: jflHM+oTQe6vxTaFNj4LbA== X-CSE-MsgGUID: apybqnzVRIWajyRaQr/WtA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,138,1770624000"; d="scan'208";a="247390848" Received: from soc-5cg4396xfb.clients.intel.com (HELO [172.28.180.189]) ([172.28.180.189]) by fmviesa002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Mar 2026 03:39:14 -0700 Message-ID: <9b17ea40-c074-4047-895f-eb9f040a67ac@linux.intel.com> Date: Tue, 24 Mar 2026 11:39:12 +0100 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5.15.y 2/2] ice: reintroduce retry mechanism for indirect AQ To: Sasha Levin , stable@vger.kernel.org Cc: Jakub Staniszewski , Michal Schmidt , Aleksandr Loktionov , Przemek Kitszel , Paul Menzel , Rinitha S , Tony Nguyen References: <2026031702-configure-decorator-0097@gregkh> <20260318004646.408222-1-sashal@kernel.org> <20260318004646.408222-2-sashal@kernel.org> Content-Language: pl, en-US From: Dawid Osuchowski Organization: Intel Technology Poland sp. z o.o. - ul. Slowackiego 173, 80-298 Gdansk - KRS 101882 - NIP 957-07-52-316 In-Reply-To: <20260318004646.408222-2-sashal@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2026-03-18 1:46 AM, Sasha Levin wrote: > From: Jakub Staniszewski > > [ Upstream commit 326256c0a72d4877cec1d4df85357da106233128 ] > > Add retry mechanism for indirect Admin Queue (AQ) commands. To do so we > need to keep the command buffer. > > This technically reverts commit 43a630e37e25 > ("ice: remove unused buffer copy code in ice_sq_send_cmd_retry()"), > but combines it with a fix in the logic by using a kmemdup() call, > making it more robust and less likely to break in the future due to > programmer error. > > Cc: Michal Schmidt > Cc: stable@vger.kernel.org > Fixes: 3056df93f7a8 ("ice: Re-send some AQ commands, as result of EBUSY AQ error") > Signed-off-by: Jakub Staniszewski > Co-developed-by: Dawid Osuchowski > Signed-off-by: Dawid Osuchowski > Reviewed-by: Aleksandr Loktionov > Reviewed-by: Przemek Kitszel > Reviewed-by: Paul Menzel > Tested-by: Rinitha S (A Contingent worker at Intel) > Signed-off-by: Tony Nguyen > [ kzalloc() => kmemdup() ] > Signed-off-by: Sasha Levin > --- Acked-by: Dawid Osuchowski I didn't have the time to test this, but the code itself looks sane :) Thanks Dawid