Re: [PATCH net 1/3] selftests: net: lib: support errexit with busywait

[Matthieu Baerts <matttbe@kernel.org>]

Hi Hangbin,

Thank you for your reply!

On 05/06/2024 11:44, Hangbin Liu wrote:
> On Wed, Jun 05, 2024 at 11:21:16AM +0200, Matthieu Baerts (NGI0) wrote:
>> If errexit is enabled ('set -e'), loopy_wait -- or busywait and others
>> using it -- will stop after the first failure.
>>
>> Note that if the returned status of loopy_wait is checked, and even if
>> errexit is enabled, Bash will not stop at the first error.
>>
>> Fixes: 25ae948b4478 ("selftests/net: add lib.sh")
> 
> Not sure if the fixes tag should be c5341bcc337c ("selftests: mlxsw: Add a
> self-test for port-default priority"), so the fixes could be backported to
> stable kernel for forwarding/lib.sh.

Good point, I didn't notice it was coming from there.

I don't think that's needed: 'net/forwarding/lib.sh' is far from being
compatible with 'errexit', please look at all the utilisations of '$?'.

For 'net/lib.sh', that's different: some functions explicitly check for
'errexit' support. If I'm not mistaken, I fixed the only place where it
was not compatible with 'errexit'.

> Others looks good to me.
> 
> Reviewed-by: Hangbin Liu <liuhangbin@gmail.com>

Thank you for the review!

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.