* [PATCH net-next v3 1/4] stmmac: loongson: Pass correct arg to PCI function
[not found] <20250224135321.36603-2-phasta@kernel.org>
@ 2025-02-24 13:53 ` Philipp Stanner
2025-02-24 19:55 ` Andrew Lunn
2025-02-25 9:00 ` Yanteng Si
0 siblings, 2 replies; 3+ messages in thread
From: Philipp Stanner @ 2025-02-24 13:53 UTC (permalink / raw)
To: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Maxime Coquelin, Alexandre Torgue, Huacai Chen,
Yanteng Si, Yinggang Gu, Feiyang Chen, Philipp Stanner,
Jiaxun Yang, Qing Zhang
Cc: netdev, linux-stm32, linux-arm-kernel, linux-kernel,
Philipp Stanner, stable
pcim_iomap_regions() should receive the driver's name as its third
parameter, not the PCI device's name.
Define the driver name with a macro and use it at the appropriate
places, including pcim_iomap_regions().
Cc: stable@vger.kernel.org # v5.14+
Fixes: 30bba69d7db4 ("stmmac: pci: Add dwmac support for Loongson")
Signed-off-by: Philipp Stanner <phasta@kernel.org>
---
drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
index bfe6e2d631bd..73a6715a93e6 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
@@ -11,6 +11,8 @@
#include "dwmac_dma.h"
#include "dwmac1000.h"
+#define DRIVER_NAME "dwmac-loongson-pci"
+
/* Normal Loongson Tx Summary */
#define DMA_INTR_ENA_NIE_TX_LOONGSON 0x00040000
/* Normal Loongson Rx Summary */
@@ -555,7 +557,7 @@ static int loongson_dwmac_probe(struct pci_dev *pdev, const struct pci_device_id
for (i = 0; i < PCI_STD_NUM_BARS; i++) {
if (pci_resource_len(pdev, i) == 0)
continue;
- ret = pcim_iomap_regions(pdev, BIT(0), pci_name(pdev));
+ ret = pcim_iomap_regions(pdev, BIT(0), DRIVER_NAME);
if (ret)
goto err_disable_device;
break;
@@ -673,7 +675,7 @@ static const struct pci_device_id loongson_dwmac_id_table[] = {
MODULE_DEVICE_TABLE(pci, loongson_dwmac_id_table);
static struct pci_driver loongson_dwmac_driver = {
- .name = "dwmac-loongson-pci",
+ .name = DRIVER_NAME,
.id_table = loongson_dwmac_id_table,
.probe = loongson_dwmac_probe,
.remove = loongson_dwmac_remove,
--
2.48.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next v3 1/4] stmmac: loongson: Pass correct arg to PCI function
2025-02-24 13:53 ` [PATCH net-next v3 1/4] stmmac: loongson: Pass correct arg to PCI function Philipp Stanner
@ 2025-02-24 19:55 ` Andrew Lunn
2025-02-25 9:00 ` Yanteng Si
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2025-02-24 19:55 UTC (permalink / raw)
To: Philipp Stanner
Cc: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Maxime Coquelin, Alexandre Torgue, Huacai Chen,
Yanteng Si, Yinggang Gu, Feiyang Chen, Philipp Stanner,
Jiaxun Yang, Qing Zhang, netdev, linux-stm32, linux-arm-kernel,
linux-kernel, stable
On Mon, Feb 24, 2025 at 02:53:19PM +0100, Philipp Stanner wrote:
> pcim_iomap_regions() should receive the driver's name as its third
> parameter, not the PCI device's name.
>
> Define the driver name with a macro and use it at the appropriate
> places, including pcim_iomap_regions().
>
> Cc: stable@vger.kernel.org # v5.14+
> Fixes: 30bba69d7db4 ("stmmac: pci: Add dwmac support for Loongson")
> Signed-off-by: Philipp Stanner <phasta@kernel.org>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next v3 1/4] stmmac: loongson: Pass correct arg to PCI function
2025-02-24 13:53 ` [PATCH net-next v3 1/4] stmmac: loongson: Pass correct arg to PCI function Philipp Stanner
2025-02-24 19:55 ` Andrew Lunn
@ 2025-02-25 9:00 ` Yanteng Si
1 sibling, 0 replies; 3+ messages in thread
From: Yanteng Si @ 2025-02-25 9:00 UTC (permalink / raw)
To: Philipp Stanner, Andrew Lunn, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Maxime Coquelin, Alexandre Torgue,
Huacai Chen, Yinggang Gu, Feiyang Chen, Philipp Stanner,
Jiaxun Yang, Qing Zhang
Cc: netdev, linux-stm32, linux-arm-kernel, linux-kernel, stable
在 2/24/25 9:53 PM, Philipp Stanner 写道:
> pcim_iomap_regions() should receive the driver's name as its third
> parameter, not the PCI device's name.
>
> Define the driver name with a macro and use it at the appropriate
> places, including pcim_iomap_regions().
>
> Cc: stable@vger.kernel.org # v5.14+
> Fixes: 30bba69d7db4 ("stmmac: pci: Add dwmac support for Loongson")
> Signed-off-by: Philipp Stanner <phasta@kernel.org>
Reviewed-by: Yanteng Si <si.yanteng@linux.dev>
Thanks,
Yanteng
> ---
> drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
> index bfe6e2d631bd..73a6715a93e6 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
> @@ -11,6 +11,8 @@
> #include "dwmac_dma.h"
> #include "dwmac1000.h"
>
> +#define DRIVER_NAME "dwmac-loongson-pci"
> +
> /* Normal Loongson Tx Summary */
> #define DMA_INTR_ENA_NIE_TX_LOONGSON 0x00040000
> /* Normal Loongson Rx Summary */
> @@ -555,7 +557,7 @@ static int loongson_dwmac_probe(struct pci_dev *pdev, const struct pci_device_id
> for (i = 0; i < PCI_STD_NUM_BARS; i++) {
> if (pci_resource_len(pdev, i) == 0)
> continue;
> - ret = pcim_iomap_regions(pdev, BIT(0), pci_name(pdev));
> + ret = pcim_iomap_regions(pdev, BIT(0), DRIVER_NAME);
> if (ret)
> goto err_disable_device;
> break;
> @@ -673,7 +675,7 @@ static const struct pci_device_id loongson_dwmac_id_table[] = {
> MODULE_DEVICE_TABLE(pci, loongson_dwmac_id_table);
>
> static struct pci_driver loongson_dwmac_driver = {
> - .name = "dwmac-loongson-pci",
> + .name = DRIVER_NAME,
> .id_table = loongson_dwmac_id_table,
> .probe = loongson_dwmac_probe,
> .remove = loongson_dwmac_remove,
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-02-25 9:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20250224135321.36603-2-phasta@kernel.org>
2025-02-24 13:53 ` [PATCH net-next v3 1/4] stmmac: loongson: Pass correct arg to PCI function Philipp Stanner
2025-02-24 19:55 ` Andrew Lunn
2025-02-25 9:00 ` Yanteng Si
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox