From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16F8EBA34; Sun, 3 May 2026 01:10:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777770639; cv=none; b=PRAxoxn6pj+OkecbMjqCwJZTnqT8HdzNKkPves4DZy28/NqAhHk23hI9R6EMOuvSwNCY1F1yyVsY2+09Ju/cFj20IM/DZjGGPZvkC/O7yuI2W+7fvWvH4LLeyaPueIFslvnf2RcGsKWEJ7Dd7/GVl/pYBaiJHuwPm5+ePi9zo0Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777770639; c=relaxed/simple; bh=Wpw01WDWUFMnyfc374OhkapxBHY/mVk4KoFrhHOR9+A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IaJFp8Al8aKhc0RYjqjdNX7W50k1Id90VUrNFIip+WkqEDVxYzpbRbhTl4FZyJC5uxgZwONSThvDipLawsKfn0LeyT0/CFUVOIr34wVitoLAG6jSPiKVmxf32dvB1tFVj7y+q1Ohr4Rb/GPbqtYL0A8ox7xr3vIc7cy++gLYAUY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=U0VXgYQT; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="U0VXgYQT" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=5toDuDb8HUCu5NENyASiLGMGq+hqOSYWxghWep45XHw=; b=U0VXgYQTEuZbtLEzdsbPumzqv7 28BuDEXmSHSm5vntkqHnwlyzpdEHNKvhqq4HMHPAtUPxRLiJaweoFybLJoiBxZO1UnDht9SgNNYn/ 4QJFY62mGJ+6NDAwC9Scwi6Doy7R+1EOlDk/bqZ8tuM1KQOsNEbGz1v04vk+ExmkBb5o=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1wJLLq-0014P4-Ga; Sun, 03 May 2026 03:10:30 +0200 Date: Sun, 3 May 2026 03:10:30 +0200 From: Andrew Lunn To: Mike Marciniszyn Cc: Simon Horman , Alexander Duyck , Jakub Kicinski , kernel-team@meta.com, Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH net] net: eth: fbnic: Fix addr validation in pcs write Message-ID: <9ec11642-8035-419c-a896-52f902020bb8@lunn.ch> References: <20260429150049.1643-1-mike.marciniszyn@gmail.com> <20260501134636.GE15617@horms.kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: > I am working inside Meta with Alex and Kuba. I noticed the one off when > doing the patch that reworks the shim. > > As to a real impact, that depends on the part2 series, but before that > series no one would care, which is why I had in as part of > the patch 1 series. > > Without the follow on work, I suspect that no one cares or would > see any issue as I have yet to present the xpcs changes in part2. > > Perhaps the best thing to do is beef up the commit and remove the > stable Cc, leaving the Fixes linkage? I'm not even sure you need the Fixes, if you say nothing is observable broken. Just make it part of the patchset, for net-next, on going development work. Andrew