From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26AD13D4137 for ; Tue, 14 Apr 2026 10:26:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776162399; cv=none; b=ZoOlid0gYK2jx/EAiCRLLAz0ry5DGE1Q6/LuxTQkqAVGOqyolQe3czXspsy5Lw/ThxeCLNARqaeVHiwJnHZfA4l3uOC24RlY4KYDRS0wU/dYBWURB3TOeIx3IQiNvRuqk3/4efwxycSwelAX0XRYwpr3macnh6Rn/5oWU8AF7wg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776162399; c=relaxed/simple; bh=ryBPjDFBhZHxlXdVvV7eSlw6JpC9aOy6QBbU9DuWzSw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jTI8Fk9ITLvy7tLyeL4ES9ZBeUoZXFwO2vT9RGq32UignSqV0kV/olFwB+lC67xtqZhIaLhUvNoSslKCFEzS+uueHXOgKAwYwXhAnxguRiFRhBb3DE41KkVNQrZYEYSUAIVVr5rOWPsc1JQzBYVCh8q9dQspSIFb39W1z+4U5/c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=iD8YaJT4; arc=none smtp.client-ip=192.198.163.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="iD8YaJT4" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1776162395; x=1807698395; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=ryBPjDFBhZHxlXdVvV7eSlw6JpC9aOy6QBbU9DuWzSw=; b=iD8YaJT4n/nA4uq/MEYfOua+wsLy9UZ9IlFokX5p2KcxR0GtguL6osce 9lcT0hDVHv/jjmqRfOYfkmCiidRkZMjpdJ6boZJjaVL5A4qZheZ9u3k9j jPpWeebggHtAWejzkzyRGnSGp1UVHLss612XbvjUmFm/MFpyfUcqrwu22 p4NpuVrRt07e6evM3X6u3jGZk8qpgFcAG3lXr//5t5JZYjXnIp8a/43Ie cfYL4YI5tSPXricFVLtNmMv/GUiC0nU5lRUnb/epz/kOrYvYuhbmCKILr SlFh16K7HFa3ntLAfNCs0BSZtpNZmm7xp8jcT/K35COGzcq9pXHm3SK5o w==; X-CSE-ConnectionGUID: xv+6djADTGGgnxIxfMLKkg== X-CSE-MsgGUID: ipmaOYHFT2KqwdHQV/K1MA== X-IronPort-AV: E=McAfee;i="6800,10657,11758"; a="102571117" X-IronPort-AV: E=Sophos;i="6.23,179,1770624000"; d="scan'208";a="102571117" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2026 03:26:32 -0700 X-CSE-ConnectionGUID: n9zZ52jyRge4c+1ydhqnBQ== X-CSE-MsgGUID: /5s86mPoRu+RAs9ZvIH8Tw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,179,1770624000"; d="scan'208";a="253279076" Received: from avbakuno-mobl.ccr.corp.intel.com (HELO [10.246.16.61]) ([10.246.16.61]) by fmviesa002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2026 03:26:30 -0700 Message-ID: <9efe2c87-fbe4-4adc-ae15-7acb3c8fe26a@linux.intel.com> Date: Tue, 14 Apr 2026 12:26:28 +0200 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [Intel-wired-lan] [PATCH iwl-net v2] i40e: Cleanup PTP pins on probe failure To: Matt Vollrath , intel-wired-lan@osuosl.org Cc: Kohei Enju , stable@vger.kernel.org References: <20260407161447.43645-1-tactii@gmail.com> Content-Language: pl, en-US From: Dawid Osuchowski Organization: Intel Technology Poland sp. z o.o. - ul. Slowackiego 173, 80-298 Gdansk - KRS 101882 - NIP 957-07-52-316 In-Reply-To: <20260407161447.43645-1-tactii@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2026-04-07 6:14 PM, Matt Vollrath wrote: > PTP pin structs are allocated early in probe, but never cleaned up. > > Fix this by calling i40e_ptp_free_pins in the error path. > > To support this, i40e_ptp_free_pins is added to the header and > pin_config is correctly nullified after being freed. > > This has been an issue since i40e_ptp_alloc_pins was introduced. > > Fixes: 1050713026a08 ("i40e: add support for PTP external synchronization clock") > Reported-by: Kohei Enju > Cc: stable@vger.kernel.org > Signed-off-by: Matt Vollrath > --- Hey Matt, I wrote a comment on your "[PATCH iwl-net v2] e1000e: Unroll PTP in probe error handling" submission about the changelog positioning and CCing stable. For this patch right here I see the Cc: tag is added correctly to the commit msg body, but the changelog is inserted in the same way as in the submission I mentioned above. Not a blocker by any means, but just wanted to let you know for future submissions to take this into account. Thanks ~Dawid