From: Sinan Kaya <Okaya@kernel.org>
To: Qasim Ijaz <qasdev00@gmail.com>
Cc: Eugen Hristev <eugen.hristev@linaro.org>,
Vinod Koul <vkoul@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 2/2] dmaengine: qcom_hidma: fix handoff FIFO memory leak on driver removal
Date: Mon, 16 Jun 2025 17:59:44 -0400 [thread overview]
Message-ID: <9fb982e6-7184-410e-94d0-90836c2a9129@kernel.org> (raw)
In-Reply-To: <aE8bu2woUe96DVo-@gmail.com>
On 6/15/2025 3:15 PM, Qasim Ijaz wrote:
> Thanks for reviewing the patch and for pointing out the correct
> shutdown ordering.
>
> If you’re both happy with it, I’ll send a v2 that calls
> tasklet_disable() before tasklet_kill(), then frees the handoff_fifo.
>
> Just let me know and I’ll resend.
Sure, please test it on a test kernel module before posting with a tasklet.
This should be straightforward to verify.
prev parent reply other threads:[~2025-06-16 21:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250601224231.24317-1-qasdev00@gmail.com>
2025-06-01 22:42 ` [PATCH 1/2] dmaengine: qcom_hidma: fix memory leak on probe failure Qasim Ijaz
2025-06-05 13:06 ` Eugen Hristev
2025-06-01 22:42 ` [PATCH 2/2] dmaengine: qcom_hidma: fix handoff FIFO memory leak on driver removal Qasim Ijaz
2025-06-05 13:04 ` Eugen Hristev
2025-06-06 13:35 ` Sinan Kaya
2025-06-15 19:15 ` Qasim Ijaz
2025-06-16 21:59 ` Sinan Kaya [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9fb982e6-7184-410e-94d0-90836c2a9129@kernel.org \
--to=okaya@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=eugen.hristev@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=qasdev00@gmail.com \
--cc=stable@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox