From: Linus Torvalds <torvalds@linux-foundation.org>
To: Joe Perches <joe@perches.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
Andy Whitcroft <apw@canonical.com>,
Andrew Morton <akpm@linux-foundation.org>,
Antonio SJ Musumeci <trapexit@spawn.link>,
Miklos Szeredi <miklos@szeredi.hu>,
Dave Jones <davej@codemonkey.org.uk>,
Oleg Nesterov <oleg@redhat.com>,
Dave Chinner <david@fromorbit.com>,
Michal Hocko <mhocko@kernel.org>, Jan Kara <jack@suse.cz>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
stable <stable@vger.kernel.org>
Subject: Re: [PATCH] checkpatch: extend BUG warning
Date: Wed, 5 Oct 2016 10:07:55 -0700 [thread overview]
Message-ID: <CA+55aFz_i6c=eV9ff0qxg4QccZ986JAedp9u72YZ7DqJM8EGLw@mail.gmail.com> (raw)
In-Reply-To: <1475686858.6105.7.camel@perches.com>
On Wed, Oct 5, 2016 at 10:00 AM, Joe Perches <joe@perches.com> wrote:
> 1838 BUILD_BUG_ON
> 632 snd_BUG_ON
At least snd_BUG_ON() is actually fine. The sound system does
something sane with their bugs: they just turn into WARN_ON()'s (and
then !CONFIG_SND_DEBUG will disable them entirely).
I haven't checked the other ones, but it was actually nice to see that
one: considering that it's the most widely used one (ignoring the
obviously great BUILD_BUG_ON), the fact that it just spews a warning
indicates that that model works fine.
Linus
next prev parent reply other threads:[~2016-10-05 17:07 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-04 4:00 BUG_ON() in workingset_node_shadows_dec() triggers Linus Torvalds
2016-10-04 4:07 ` Andrew Morton
2016-10-04 4:12 ` Linus Torvalds
2016-10-04 7:03 ` Raymond Jennings
2016-10-04 16:03 ` Linus Torvalds
2016-10-04 8:02 ` Greg KH
2016-10-04 9:32 ` Johannes Weiner
2016-10-05 1:21 ` Linus Torvalds
2016-10-05 9:25 ` Johannes Weiner
2016-10-05 9:31 ` Johannes Weiner
2016-10-05 10:40 ` Jan Kara
2016-10-05 16:10 ` Linus Torvalds
2016-10-05 17:00 ` [PATCH] checkpatch: extend BUG warning Joe Perches
2016-10-05 17:07 ` Linus Torvalds [this message]
2016-10-05 2:43 ` BUG_ON() in workingset_node_shadows_dec() triggers Paul Gortmaker
2016-10-05 3:29 ` Linus Torvalds
2016-10-05 5:44 ` Willy Tarreau
2016-10-05 15:52 ` Linus Torvalds
2016-10-05 19:06 ` Willy Tarreau
2016-10-05 19:18 ` Linus Torvalds
2016-10-05 21:09 ` Willy Tarreau
2016-10-05 21:14 ` Kees Cook
2016-10-05 21:46 ` Linus Torvalds
2016-10-05 22:17 ` Kees Cook
2016-10-05 22:29 ` Linus Torvalds
2016-10-06 22:07 ` Kees Cook
2016-10-06 22:29 ` Linus Torvalds
2016-10-06 23:05 ` Kees Cook
2016-10-06 23:59 ` Linus Torvalds
2016-10-07 5:48 ` Willy Tarreau
2016-10-07 17:16 ` Kees Cook
2016-10-07 17:21 ` Linus Torvalds
2016-10-07 17:33 ` Kees Cook
2016-10-07 18:26 ` Willy Tarreau
2016-10-06 1:59 ` Dave Chinner
2016-10-06 2:12 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+55aFz_i6c=eV9ff0qxg4QccZ986JAedp9u72YZ7DqJM8EGLw@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=davej@codemonkey.org.uk \
--cc=david@fromorbit.com \
--cc=hannes@cmpxchg.org \
--cc=jack@suse.cz \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@kernel.org \
--cc=miklos@szeredi.hu \
--cc=oleg@redhat.com \
--cc=stable@vger.kernel.org \
--cc=trapexit@spawn.link \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).