From: "Luis R. Rodriguez" <mcgrof@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Yves-Alexis Perez <corsac@corsac.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Yves-Alexis Perez <corsac@debian.org>,
Ming Lei <ming.lei@canonical.com>,
Johannes Berg <johannes@sipsolutions.net>,
Jouni Malinen <j@w1.fi>, Kees Cook <keescook@chromium.org>,
Jiri Kosina <jkosina@suse.cz>, Jiri Slaby <jslaby@suse.com>,
Tom Gundersen <teg@jklm.no>, Kay Sievers <kay@vrfy.org>,
Josh Boyer <jwboyer@fedoraproject.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Andy Lutomirski <luto@amacapital.net>,
Harald Hoyer <harald@redhat.com>,
Seth Forshee <seth.forshee@canonical.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Daniel Wagner <wagi@monom.org>, "4.2+" <stable@vger.kernel.org>
Subject: Re: [PATCH] firmware: fix async/manual firmware loading
Date: Thu, 10 Nov 2016 11:49:08 -0800 [thread overview]
Message-ID: <CAB=NE6UHWvk-ReSfKYzRtex8GreJjpGMsp4_-TLBDBme0=hEDw@mail.gmail.com> (raw)
In-Reply-To: <20161110191836.GB4775@kroah.com>
On Thu, Nov 10, 2016 at 11:18 AM, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> On Thu, Nov 10, 2016 at 08:07:58AM -0800, Luis R. Rodriguez wrote:
>> > It shouldn't be hard to figure out if a patch should be in stable or not...
>>
>> Well with the only caveat now that I am suggesting we consider remove
>> this logic completely as only 2 drivers were using it explicitly
>> (second argument to request_firmware_nowait() set to false), it seems
>> they had good reasons for it but ... this has been broken for ages and
>> we seem to be happy to compartamentalize the UMH further, its unclear
>> why we would want to expand and "fix" that instead of just removing
>> crap that never worked. Thoughts?
>
> Why would you want to remove stuff that works and people rely on? Don't
> be foolish, you know we can't do that...
I was not advocating removing it if it had worked, I advocated
removing it if it truly was something that never worked.
Luis
prev parent reply other threads:[~2016-11-10 19:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20161030145048.6291-1-corsac@corsac.net>
2016-10-30 14:50 ` [PATCH] firmware: fix async/manual firmware loading Yves-Alexis Perez
2016-10-30 17:28 ` Yves-Alexis Perez
2016-11-09 20:36 ` Luis R. Rodriguez
2016-11-09 22:02 ` Luis R. Rodriguez
2016-11-10 6:57 ` Yves-Alexis Perez
2016-11-09 20:39 ` Luis R. Rodriguez
2016-11-10 15:55 ` Greg Kroah-Hartman
2016-11-10 16:07 ` Luis R. Rodriguez
2016-11-10 18:52 ` Bjorn Andersson
2016-11-10 19:48 ` Luis R. Rodriguez
2016-11-10 21:04 ` Yves-Alexis Perez
2016-11-10 21:22 ` Luis R. Rodriguez
2016-11-10 19:18 ` Greg Kroah-Hartman
2016-11-10 19:49 ` Luis R. Rodriguez [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAB=NE6UHWvk-ReSfKYzRtex8GreJjpGMsp4_-TLBDBme0=hEDw@mail.gmail.com' \
--to=mcgrof@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=corsac@corsac.net \
--cc=corsac@debian.org \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=harald@redhat.com \
--cc=j@w1.fi \
--cc=jkosina@suse.cz \
--cc=johannes@sipsolutions.net \
--cc=jslaby@suse.com \
--cc=jwboyer@fedoraproject.org \
--cc=kay@vrfy.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=ming.lei@canonical.com \
--cc=seth.forshee@canonical.com \
--cc=stable@vger.kernel.org \
--cc=teg@jklm.no \
--cc=wagi@monom.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).