From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-f194.google.com ([209.85.223.194]:38715 "EHLO mail-io0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753089AbeFGHZO (ORCPT ); Thu, 7 Jun 2018 03:25:14 -0400 Received: by mail-io0-f194.google.com with SMTP id l19-v6so10673418ioj.5 for ; Thu, 07 Jun 2018 00:25:14 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <7c34ccef-2fa8-8b53-2677-29f6fbe71a04@dd-wrt.com> References: <20180528100240.256525891@linuxfoundation.org> <20180528100302.722883806@linuxfoundation.org> <7c34ccef-2fa8-8b53-2677-29f6fbe71a04@dd-wrt.com> From: Linus Walleij Date: Thu, 7 Jun 2018 09:25:12 +0200 Message-ID: Subject: Re: [PATCH 4.16 269/272] pinctrl: msm: Use dynamic GPIO numbering To: Sebastian Gottschall Cc: Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" , stable , Timur Tabi , Bjorn Andersson , Sasha Levin Content-Type: text/plain; charset="UTF-8" Sender: stable-owner@vger.kernel.org List-ID: On Thu, May 31, 2018 at 1:21 PM, Sebastian Gottschall wrote: > this patch creates a regression for me. on ipq8064 the systems gpios now > start somewhere in the sky (...) > this broke my userspace gpio handling. i can override this, but still it > doesnt look correct since there is a hole at the beginng likelly reserved by > unused arm gpios Out of curiosity: what is this userspace? We do not break userspace, so I guess we should put in some hack to keep the base 0 on ipq8064 then, but as pointed out by Bjorn there will be problems when we get multiple gpiochips in later platforms so it is just a stopgap solution. Have you looked into using the new character device with your userspace, either as shown in the examples: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/tools/gpio or using libgpiod: https://git.kernel.org/pub/scm/libs/libgpiod/libgpiod.git/ Yours, Linus Walleij