From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f66.google.com ([209.85.215.66]:38132 "EHLO mail-lf0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964776AbeBMNeK (ORCPT ); Tue, 13 Feb 2018 08:34:10 -0500 MIME-Version: 1.0 In-Reply-To: <20180209133934.259299920@linuxfoundation.org> References: <20180209133931.211869118@linuxfoundation.org> <20180209133934.259299920@linuxfoundation.org> From: Nick Lowe Date: Tue, 13 Feb 2018 13:34:07 +0000 Message-ID: Subject: Re: [PATCH 4.9 43/92] x86/pti: Do not enable PTI on CPUs which are not vulnerable to Meltdown To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, David Woodhouse , Thomas Gleixner , Borislav Petkov , Dave Hansen , gnomes@lxorguk.ukuu.org.uk, ak@linux.intel.com, ashok.raj@intel.com, karahmed@amazon.de, arjan@linux.intel.com, torvalds@linux-foundation.org, peterz@infradead.org, Borislav Petkov , pbonzini@redhat.com, tim.c.chen@linux.intel.com, gregkh@linux-foundation.org Content-Type: text/plain; charset="UTF-8" Sender: stable-owner@vger.kernel.org List-ID: Hi, This does not seem to have subsumed the AMD specific code in x86/pti: Do not enable PTI on CPUs which are not vulnerable to Meltdown Commit a8799fd14d9f7f385a5a5c86cde247caf4bb0320 https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/commit/?h=v4.9.81&id=a8799fd14d9f7f385a5a5c86cde247caf4bb0320 x86/kaiser: Check boottime cmdline params Commit 8018307a45a90ab2eecfd03d48b7efb31707df37 https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/commit/arch/x86/mm/kaiser.c?h=v4.9.75&id=8018307a45a90ab2eecfd03d48b7efb31707df37 Here, we can see: +skip: + if (boot_cpu_data.x86_vendor == X86_VENDOR_AMD) + goto disable; Refer to 4.9.81's kaiser.c https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/tree/arch/x86/mm/kaiser.c?h=v4.9.81 Also 4.4.115's kaiser.c https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/tree/arch/x86/mm/kaiser.c?h=v4.4.115 Cheers, Nick