public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/amd/display: Use GFP_ATOMIC in dc_create_stream_for_sink
@ 2026-02-23 11:45 Natalie Vock
  2026-02-24 14:56 ` Alex Deucher
  0 siblings, 1 reply; 2+ messages in thread
From: Natalie Vock @ 2026-02-23 11:45 UTC (permalink / raw)
  To: Harry Wentland, Leo Li, Rodrigo Siqueira; +Cc: amd-gfx, stable

This can be called while preemption is disabled, for example by
dcn32_internal_validate_bw which is called with the FPU active.

Fixes "BUG: scheduling while atomic" messages I encounter on my Navi31
machine.

Cc: stable@vger.kernel.org

Signed-off-by: Natalie Vock <natalie.vock@gmx.de>
---
 drivers/gpu/drm/amd/display/dc/core/dc_stream.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_stream.c b/drivers/gpu/drm/amd/display/dc/core/dc_stream.c
index 191f6435e7c64..87c0cf7e290ea 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc_stream.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc_stream.c
@@ -170,11 +170,11 @@ struct dc_stream_state *dc_create_stream_for_sink(
 	if (sink == NULL)
 		goto fail;
 
-	stream = kzalloc(sizeof(struct dc_stream_state), GFP_KERNEL);
+	stream = kzalloc(sizeof(struct dc_stream_state), GFP_ATOMIC);
 	if (stream == NULL)
 		goto fail;
 
-	stream->update_scratch = kzalloc((int32_t) dc_update_scratch_space_size(), GFP_KERNEL);
+	stream->update_scratch = kzalloc((int32_t) dc_update_scratch_space_size(), GFP_ATOMIC);
 	if (stream->update_scratch == NULL)
 		goto fail;
 
-- 
2.53.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] drm/amd/display: Use GFP_ATOMIC in dc_create_stream_for_sink
  2026-02-23 11:45 [PATCH] drm/amd/display: Use GFP_ATOMIC in dc_create_stream_for_sink Natalie Vock
@ 2026-02-24 14:56 ` Alex Deucher
  0 siblings, 0 replies; 2+ messages in thread
From: Alex Deucher @ 2026-02-24 14:56 UTC (permalink / raw)
  To: Natalie Vock; +Cc: Harry Wentland, Leo Li, Rodrigo Siqueira, amd-gfx, stable

Applied.  Thanks!

On Mon, Feb 23, 2026 at 9:34 AM Natalie Vock <natalie.vock@gmx.de> wrote:
>
> This can be called while preemption is disabled, for example by
> dcn32_internal_validate_bw which is called with the FPU active.
>
> Fixes "BUG: scheduling while atomic" messages I encounter on my Navi31
> machine.
>
> Cc: stable@vger.kernel.org
>
> Signed-off-by: Natalie Vock <natalie.vock@gmx.de>
> ---
>  drivers/gpu/drm/amd/display/dc/core/dc_stream.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_stream.c b/drivers/gpu/drm/amd/display/dc/core/dc_stream.c
> index 191f6435e7c64..87c0cf7e290ea 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_stream.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_stream.c
> @@ -170,11 +170,11 @@ struct dc_stream_state *dc_create_stream_for_sink(
>         if (sink == NULL)
>                 goto fail;
>
> -       stream = kzalloc(sizeof(struct dc_stream_state), GFP_KERNEL);
> +       stream = kzalloc(sizeof(struct dc_stream_state), GFP_ATOMIC);
>         if (stream == NULL)
>                 goto fail;
>
> -       stream->update_scratch = kzalloc((int32_t) dc_update_scratch_space_size(), GFP_KERNEL);
> +       stream->update_scratch = kzalloc((int32_t) dc_update_scratch_space_size(), GFP_ATOMIC);
>         if (stream->update_scratch == NULL)
>                 goto fail;
>
> --
> 2.53.0
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-02-24 14:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-23 11:45 [PATCH] drm/amd/display: Use GFP_ATOMIC in dc_create_stream_for_sink Natalie Vock
2026-02-24 14:56 ` Alex Deucher

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox