[PATCH] cifs: make default value of retrans as zero

[PATCH] cifs: make default value of retrans as zero

[nspmangalore]

From: Shyam Prasad N <sprasad@microsoft.com>

When retrans mount option was introduced, the default value was set
as 1. However, in the light of some bugs that this has exposed recently
we should change it to 0 and retain the old behaviour before this option
was introduced.

Cc: <stable@vger.kernel.org>
Signed-off-by: Shyam Prasad N <sprasad@microsoft.com>
---
 fs/smb/client/fs_context.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/smb/client/fs_context.c b/fs/smb/client/fs_context.c
index 54090739535fb..a4a7c7eee038c 100644
--- a/fs/smb/client/fs_context.c
+++ b/fs/smb/client/fs_context.c
@@ -1997,7 +1997,7 @@ int smb3_init_fs_context(struct fs_context *fc)
 	ctx->backupuid_specified = false; /* no backup intent for a user */
 	ctx->backupgid_specified = false; /* no backup intent for a group */
 
-	ctx->retrans = 1;
+	ctx->retrans = 0;
 	ctx->reparse_type = CIFS_REPARSE_TYPE_DEFAULT;
 	ctx->symlink_type = CIFS_SYMLINK_TYPE_DEFAULT;
 	ctx->nonativesocket = 0;
-- 
2.43.0

Re: [PATCH] cifs: make default value of retrans as zero

[Bharath SM]

On Tue, Mar 10, 2026 at 10:19 PM <nspmangalore@gmail.com> wrote:
>
> From: Shyam Prasad N <sprasad@microsoft.com>
>
> When retrans mount option was introduced, the default value was set
> as 1. However, in the light of some bugs that this has exposed recently
> we should change it to 0 and retain the old behaviour before this option
> was introduced.
>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Shyam Prasad N <sprasad@microsoft.com>
> ---
>  fs/smb/client/fs_context.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/smb/client/fs_context.c b/fs/smb/client/fs_context.c
> index 54090739535fb..a4a7c7eee038c 100644
> --- a/fs/smb/client/fs_context.c
> +++ b/fs/smb/client/fs_context.c
> @@ -1997,7 +1997,7 @@ int smb3_init_fs_context(struct fs_context *fc)
>         ctx->backupuid_specified = false; /* no backup intent for a user */
>         ctx->backupgid_specified = false; /* no backup intent for a group */
>
> -       ctx->retrans = 1;
> +       ctx->retrans = 0;
>         ctx->reparse_type = CIFS_REPARSE_TYPE_DEFAULT;
>         ctx->symlink_type = CIFS_SYMLINK_TYPE_DEFAULT;
>         ctx->nonativesocket = 0;
> --
> 2.43.0

Thanks, Looks good to me.

Re: [PATCH] cifs: make default value of retrans as zero

[Steve French]

added to cifs-2.6.git for-next pending additional testing and reviews

On Wed, Mar 11, 2026 at 12:26 AM Bharath SM <bharathsm.hsk@gmail.com> wrote:
>
> On Tue, Mar 10, 2026 at 10:19 PM <nspmangalore@gmail.com> wrote:
> >
> > From: Shyam Prasad N <sprasad@microsoft.com>
> >
> > When retrans mount option was introduced, the default value was set
> > as 1. However, in the light of some bugs that this has exposed recently
> > we should change it to 0 and retain the old behaviour before this option
> > was introduced.
> >
> > Cc: <stable@vger.kernel.org>
> > Signed-off-by: Shyam Prasad N <sprasad@microsoft.com>
> > ---
> >  fs/smb/client/fs_context.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fs/smb/client/fs_context.c b/fs/smb/client/fs_context.c
> > index 54090739535fb..a4a7c7eee038c 100644
> > --- a/fs/smb/client/fs_context.c
> > +++ b/fs/smb/client/fs_context.c
> > @@ -1997,7 +1997,7 @@ int smb3_init_fs_context(struct fs_context *fc)
> >         ctx->backupuid_specified = false; /* no backup intent for a user */
> >         ctx->backupgid_specified = false; /* no backup intent for a group */
> >
> > -       ctx->retrans = 1;
> > +       ctx->retrans = 0;
> >         ctx->reparse_type = CIFS_REPARSE_TYPE_DEFAULT;
> >         ctx->symlink_type = CIFS_SYMLINK_TYPE_DEFAULT;
> >         ctx->nonativesocket = 0;
> > --
> > 2.43.0
>
> Thanks, Looks good to me.



-- 
Thanks,

Steve