[PATCH] thermal: intel: int340x: Power Slider: Set offset only for balanced mode

[PATCH] thermal: intel: int340x: Power Slider: Set offset only for balanced mode

[Srinivas Pandruvada]

The slider offset can be set via debugfs for balanced mode. The offset
should be only applicable in balanced mode. For other modes, it should
be set 0 when writing to MMIO offset,

Fixes: 8306bcaba06d ("thermal: intel: int340x: Add module parameter to change slider offset")
Tested-by: Erin Park <erin.park@intel.com>
Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: stable@vger.kernel.org # v6.18+
---
 .../intel/int340x_thermal/processor_thermal_soc_slider.c  | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/thermal/intel/int340x_thermal/processor_thermal_soc_slider.c b/drivers/thermal/intel/int340x_thermal/processor_thermal_soc_slider.c
index 49ff3bae7271..91f291627132 100644
--- a/drivers/thermal/intel/int340x_thermal/processor_thermal_soc_slider.c
+++ b/drivers/thermal/intel/int340x_thermal/processor_thermal_soc_slider.c
@@ -176,15 +176,21 @@ static inline void write_soc_slider(struct proc_thermal_device *proc_priv, u64 v
 
 static void set_soc_power_profile(struct proc_thermal_device *proc_priv, int slider)
 {
+	u8 offset;
 	u64 val;
 
 	val = read_soc_slider(proc_priv);
 	val &= ~SLIDER_MASK;
 	val |= FIELD_PREP(SLIDER_MASK, slider) | BIT(SLIDER_ENABLE_BIT);
 
+	if (slider == SOC_SLIDER_VALUE_MINIMUM || slider == SOC_SLIDER_VALUE_MAXIMUM)
+		offset = 0;
+	else
+		offset = slider_offset;
+
 	/* Set the slider offset from module params */
 	val &= ~SLIDER_OFFSET_MASK;
-	val |= FIELD_PREP(SLIDER_OFFSET_MASK, slider_offset);
+	val |= FIELD_PREP(SLIDER_OFFSET_MASK, offset);
 
 	write_soc_slider(proc_priv, val);
 }
-- 
2.52.0

Re: [PATCH] thermal: intel: int340x: Power Slider: Set offset only for balanced mode

[Rafael J. Wysocki]

On Tue, Mar 24, 2026 at 6:23 PM Srinivas Pandruvada
<srinivas.pandruvada@linux.intel.com> wrote:
>
> The slider offset can be set via debugfs for balanced mode. The offset
> should be only applicable in balanced mode. For other modes, it should
> be set 0 when writing to MMIO offset,
>
> Fixes: 8306bcaba06d ("thermal: intel: int340x: Add module parameter to change slider offset")
> Tested-by: Erin Park <erin.park@intel.com>
> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> Cc: stable@vger.kernel.org # v6.18+
> ---
>  .../intel/int340x_thermal/processor_thermal_soc_slider.c  | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/intel/int340x_thermal/processor_thermal_soc_slider.c b/drivers/thermal/intel/int340x_thermal/processor_thermal_soc_slider.c
> index 49ff3bae7271..91f291627132 100644
> --- a/drivers/thermal/intel/int340x_thermal/processor_thermal_soc_slider.c
> +++ b/drivers/thermal/intel/int340x_thermal/processor_thermal_soc_slider.c
> @@ -176,15 +176,21 @@ static inline void write_soc_slider(struct proc_thermal_device *proc_priv, u64 v
>
>  static void set_soc_power_profile(struct proc_thermal_device *proc_priv, int slider)
>  {
> +       u8 offset;
>         u64 val;
>
>         val = read_soc_slider(proc_priv);
>         val &= ~SLIDER_MASK;
>         val |= FIELD_PREP(SLIDER_MASK, slider) | BIT(SLIDER_ENABLE_BIT);
>
> +       if (slider == SOC_SLIDER_VALUE_MINIMUM || slider == SOC_SLIDER_VALUE_MAXIMUM)
> +               offset = 0;
> +       else
> +               offset = slider_offset;
> +
>         /* Set the slider offset from module params */
>         val &= ~SLIDER_OFFSET_MASK;
> -       val |= FIELD_PREP(SLIDER_OFFSET_MASK, slider_offset);
> +       val |= FIELD_PREP(SLIDER_OFFSET_MASK, offset);
>
>         write_soc_slider(proc_priv, val);
>  }
> --

Applied as 7.0-rc material, thanks!