From: Rashika Kheria <rashika.kheria@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: opw-kernel <opw-kernel@googlegroups.com>,
Minchan Kim <minchan@kernel.org>,
Jiang Liu <jiang.liu@huawei.com>, Nitin Gupta <ngupta@vflare.org>,
Jerome Marchand <jmarchand@redhat.com>,
Linux-Kernel <linux-kernel@vger.kernel.org>,
stable@vger.kernel.org
Subject: Re: [OPW kernel] Re: [PATCH v10] Staging: zram: Fix memory leak by refcount mismatch
Date: Sun, 10 Nov 2013 21:26:15 +0530 [thread overview]
Message-ID: <CAMpEsFGXz5vo4u42MH29eZ8oBC3JB-p6+rvuLWhBZXmMWdL7TQ@mail.gmail.com> (raw)
In-Reply-To: <20131110154522.GA28926@kroah.com>
On Sun, Nov 10, 2013 at 9:15 PM, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> On Fri, Nov 01, 2013 at 07:36:09PM +0530, Rashika Kheria wrote:
>> As suggested by Minchan Kim and Jerome Marchand "The code in reset_store
>> get the block device (bdget_disk()) but it does not put it (bdput()) when
>> it's done using it. The usage count is therefore incremented but never
>> decremented."
>>
>> This patch also puts bdput() for all error cases.
>>
>> Acked-by: Minchan Kim <minchan@kernel.org>
>> Acked-by: Jerome Marchand <jmarchan@redhat.com>
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
>> ---
>>
>> This revision fixes the following issue of the previous revision-
>> Incorrect Subject Line
>
> I'm a bit confused now, I see three different zram patches from you,
> with different subjects, are they all now just in one patch, this one?
>
> Can you just send me the outstanding zram patches that you have gotten
> acks from that you want applied, as I'm lost here.
>
> thanks,
>
> greg "easily confused" k-h
>
Hi Greg,
You have already applied the rest two patches for this driver. This is
the only patch which is left.
But I think you might have problem applying this because there have
been changes in previous patches later i.e you applied v8 of this
series, while, maintainers later suggested to change more and hence v9
was also introduced.
Therefore, v9's patch 1 and v10 patch is correct to be applied in the tree.
Thanks,
--
Rashika Kheria
B.Tech CSE
IIIT Hyderabad
next prev parent reply other threads:[~2013-11-10 15:56 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20131019110539.GA25167@gmail.com>
2013-10-29 23:10 ` [PATCH v7 1/3] Staging: zram: Fix access of NULL pointer Rashika Kheria
2013-10-29 23:12 ` [PATCH v7 2/3] Staging: zram: Fix decrement of variable by calling bdput() Rashika Kheria
2013-10-30 2:33 ` Minchan Kim
2013-10-29 23:15 ` [PATCH v7 3/3] Staging: zram: Fix variable dereferenced before check Rashika Kheria
2013-10-30 2:35 ` Minchan Kim
2013-10-30 10:44 ` Jerome Marchand
2013-10-30 2:24 ` [PATCH v7 1/3] Staging: zram: Fix access of NULL pointer Minchan Kim
2013-10-30 2:36 ` Minchan Kim
2013-10-30 10:42 ` Jerome Marchand
2013-10-30 13:06 ` [PATCH v8 " Rashika Kheria
2013-10-30 13:10 ` [PATCH v8 2/3] Staging: zram: Fix decrement of variable by calling bdput() Rashika Kheria
2013-10-31 9:42 ` Weijie Yang
2013-10-31 11:56 ` [PATCH v9 1/2] Staging: zram: Fix access of NULL pointer Rashika Kheria
2013-10-31 11:58 ` [PATCH v9 2/2] Staging: zram: Fix decrement of variable by calling bdput() Rashika Kheria
2013-11-01 2:00 ` Minchan Kim
2013-11-01 8:54 ` Jerome Marchand
2013-11-01 14:13 ` Rashika Kheria
2013-11-01 14:06 ` [PATCH v10] Staging: zram: Fix memory leak by refcount mismatch Rashika Kheria
2013-11-10 15:45 ` Greg Kroah-Hartman
2013-11-10 15:56 ` Rashika Kheria [this message]
2013-11-10 16:10 ` [OPW kernel] " Greg Kroah-Hartman
2013-11-10 16:14 ` Rashika Kheria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMpEsFGXz5vo4u42MH29eZ8oBC3JB-p6+rvuLWhBZXmMWdL7TQ@mail.gmail.com \
--to=rashika.kheria@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jiang.liu@huawei.com \
--cc=jmarchand@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
--cc=opw-kernel@googlegroups.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).