From: Michael Jin <mikhail.jin@gmail.com>
To: "Ghannam, Yazen" <Yazen.Ghannam@amd.com>
Cc: Borislav Petkov <bp@suse.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH V2] EDAC, amd64: Add Family 17h Model 10h support.
Date: Thu, 16 Aug 2018 15:39:17 -0400 [thread overview]
Message-ID: <CAO6F7DmPHBpf299g40pzUAbL-JK5S2eNbhwXN0kVmLhtwcqDqQ@mail.gmail.com> (raw)
In-Reply-To: <BN7PR12MB2593B097267132250140FBEAF83E0@BN7PR12MB2593.namprd12.prod.outlook.com>
On Thu, Aug 16, 2018 at 2:17 PM, Ghannam, Yazen <Yazen.Ghannam@amd.com> wrote:
>> -----Original Message-----
>> From: Michael Jin <mikhail.jin@gmail.com>
>> Sent: Wednesday, August 15, 2018 6:41 AM
>> To: Borislav Petkov <bp@suse.de>; Ghannam, Yazen
>> <Yazen.Ghannam@amd.com>; Mauro Carvalho Chehab
>> <mchehab@kernel.org>
>> Cc: linux-edac@vger.kernel.org; linux-kernel@vger.kernel.org; Michael Jin
>> <mikhail.jin@gmail.com>; stable@vger.kernel.org
>> Subject: [PATCH V2] EDAC, amd64: Add Family 17h Model 10h support.
>>
>> Add support for ECC error decoding on family 17h models 10h-2fh.
>>
>
> Can you please make this more specific? Something like "Add PCI device IDs
> for Fam17h Models 10h-2Fh so that amd64_edac_mod will load".
I have submitted patch v3 with a commit message that is more specific.
>> case 0x17:
>> + /* Check if CPU model is in range 10h-2fh */
>
> This comment is not needed because it's obvious from the code.
The comment in patch v2 has been removed in patch v3.
Thanks,
Michael
next prev parent reply other threads:[~2018-08-16 19:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-15 11:41 [PATCH V2] EDAC, amd64: Add Family 17h Model 10h support Michael Jin
2018-08-16 18:17 ` Ghannam, Yazen
2018-08-16 19:39 ` Michael Jin [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-08-15 11:32 Michael Jin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAO6F7DmPHBpf299g40pzUAbL-JK5S2eNbhwXN0kVmLhtwcqDqQ@mail.gmail.com \
--to=mikhail.jin@gmail.com \
--cc=Yazen.Ghannam@amd.com \
--cc=bp@suse.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).