From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vk1-f176.google.com (mail-vk1-f176.google.com [209.85.221.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 37792220686 for ; Tue, 14 Oct 2025 09:48:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760435313; cv=none; b=lZjEpcRzm0IiL0KPWNccH+50PJBB41Cfd7tKcs61nn2+7f2wl01OTrlgF+ZF17HZeEHPClfIYe5DoVrImNxXG/eiDe4yBz/TMDKutGOwfWiTXV1w+gjpFwyMxgob3vaVYLKp4XZWK64CHXorHAmAOktMEH8iJd0Ax5I8A73GZbY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760435313; c=relaxed/simple; bh=kHtxBRJjtARoemyv0wYK4lb2xYVXtiqIKZY9jw9d9PU=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:From:To:Cc: References:In-Reply-To; b=I3o5yPxzQWEinBK7hsEgmpQ0y7zQyytOfCYgwjVNV+BXA2ga0gfQdlbZQ7mXc6JjvxjYW98M4LAh8TT9tLY7SX3CsXJ95kVEpb+c7daNUDAJCiOoWT3d1VgIYurRLII8cuOSflBUU7ZddQie7jQ6ZnOHQF4nz7C1CEgZopfd2wU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ClkgYJg3; arc=none smtp.client-ip=209.85.221.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ClkgYJg3" Received: by mail-vk1-f176.google.com with SMTP id 71dfb90a1353d-54aa30f4093so1681800e0c.3 for ; Tue, 14 Oct 2025 02:48:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1760435310; x=1761040110; darn=vger.kernel.org; h=in-reply-to:references:cc:to:from:subject:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=LG0ED4pWkkVj5n94lraCEC5DO5yZd4ntTF5w7MamzsU=; b=ClkgYJg3ZFFg/dqfrMmCuaIbGbomsnLKgHgxxwSFZsR7yXtwgtmGUoS+2XAMqDzDVv vLXfo7iY76PzIxEpm1iPMkDS21jCur0PYugttmX6/ngvGWGLqaOwIAAFdikhGSyMRx23 r+XrXloDipTpfiI+JV48nbZCo1tfT+vQ0DoVkGeWS+nUL3RQlLvfFz7vCX42TvCrYskn 6hq0+qhMWwMENx5F2hJ4GFU3ksYXhMuhQnn750VklgpMKdAGoKUDitPnBinOol2itdaJ UL4VUM1f+GByKDnR7ZWyh3NrqSFJcSttBhdLbJ+4OQkdEXj8L7mqAj90jCsH35iR6Ymb u9MQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760435310; x=1761040110; h=in-reply-to:references:cc:to:from:subject:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=LG0ED4pWkkVj5n94lraCEC5DO5yZd4ntTF5w7MamzsU=; b=WPiksx/wtkBoKnHt0nLmiAwisalFCYWkk72JXogeRD5hGnbPIyYHaaH/J1e9whA8oz xRhyNwAXutbHM5U4IFhZxjZiBzQ5Pe05fFnJ4BggTI2L34MdBfIU+FZCDWZfLb+82v7t CHI13BjDLBkgWXedmRj7blisEmK+w1iWICObEILEfBXr+Ix3GBoHzMI+5SJT4JNaJ3eB Ra38cse0sE6FQPxM6iv82ojcYs5YShSc3+eu2AXjfXKfTB7inYLbweFr8ofEjar0oklp 41vsbY10eaUp/opnGlR3fXVOPl+CgCjif6kqJkV7mOJza1ECHe4CsKBcnO7Cqv6ILeiN ncBA== X-Forwarded-Encrypted: i=1; AJvYcCUUOs3Qv4X/IM+PLKuvUWa1MMCeMJ2F0G8DUHxFZkO8S9wZu7hX1Wcb/uHNioWUwo9Qvk1VWIE=@vger.kernel.org X-Gm-Message-State: AOJu0YwDGoRYsy4dMCF3n2Eypfxw1CheTL38t6/8J8ythQGTJXEE8rQC r5nEFFWbMvTwPIkjjOKf1G8t9r8BJRk9Hci0nYlVSSPRgKdKIM1oF70Q X-Gm-Gg: ASbGncsCCg/CfmfYRbT3r2z1geZwgaJTNxNvX6m8Qqfvf50RkecpSNtJhd+Qwf8gDVK ow1dqqC7weDyqOrLA5Zd1ud6nxSLXAAOs4ImGJuJY7owq3NhDdS2hnTKSJbZz/6LsXNE8X1QlP5 UMw6m1RCjuOxRNM+eXDpWuGoLT5ASkjjzKPgqhmqaEgEq5QgoXhu6j/LVu+qdvXnrpih185jjjd rby1dWidCDCxhMGBC9+p6w/rH5MEK7WcSE5QBDEaNhzlkpoMWVe+/SsfIDZnKbYMpgzTLWGJa79 b0qhINWgdD4gP7Q5LK+lBxMpvCTjLb+5KMNpABsjAwXXRZ3fvWVjWohNpPKjm2OCRAaGkUDMeIp sX6Q5HF0+a+UlOSa1jB0lcyowzmRIK29hEQQU+veUYJFG X-Google-Smtp-Source: AGHT+IF6H47KZGz8Lq6nVOeRN/dL+wwxgitHPIZLOq8wuKUhsfrWL6NL4IjUjZ54gMcdy/8Rww7YmQ== X-Received: by 2002:a05:6102:2acd:b0:5d5:fefc:9fd0 with SMTP id ada2fe7eead31-5d5fefca0d5mr4008750137.0.1760435310123; Tue, 14 Oct 2025 02:48:30 -0700 (PDT) Received: from localhost ([2800:bf0:82:3d2:875c:6c76:e06b:3095]) by smtp.gmail.com with ESMTPSA id a1e0cc1a2514c-930bf6ce034sm3474678241.7.2025.10.14.02.48.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Oct 2025 02:48:29 -0700 (PDT) Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 14 Oct 2025 04:48:28 -0500 Message-Id: Subject: Re: [PATCH v2] platform/x86: alienware-wmi-wmax: Fix null pointer derefence in sleep handlers From: "Kurt Borja" To: =?utf-8?q?Ilpo_J=C3=A4rvinen?= , "Hans de Goede" , "Armin Wolf" , "Kurt Borja" Cc: , , , , "Gal Hammer" X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20251013-sleep-fix-v2-1-1ad8bdb79585@gmail.com> <176036823039.2473.15648931584117338012.b4-ty@linux.intel.com> In-Reply-To: <176036823039.2473.15648931584117338012.b4-ty@linux.intel.com> On Mon Oct 13, 2025 at 10:10 AM -05, Ilpo J=C3=A4rvinen wrote: > On Mon, 13 Oct 2025 00:26:26 -0500, Kurt Borja wrote: > >> Initialize `awcc` with empty quirks to avoid a null pointer dereference >> in sleep handlers for devices without the AWCC interface. >>=20 >> This also allows some code simplification in alienware_wmax_wmi_init(). >>=20 >>=20 > > > Thank you for your contribution, it has been applied to my local > review-ilpo-fixes branch. Note it will show up in the public > platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my > local branch there, which might take a while. > > The list of commits applied: > [1/1] platform/x86: alienware-wmi-wmax: Fix null pointer derefence in sle= ep handlers > commit: 5ae9382ac3c56d044ed065d0ba6d8c42139a8f98 > > -- > i. Hi Ilpo, Gal has just noticed this approach prevents the old driver interface from loading, which is a huge regression. Do you prefer to drop this commit or should I submit a revert? Thank you for your patience! --=20 ~ Kurt