public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
* ba1b40ed0e34bab597fd90d4c4e9f7397f878c8f for 6.18.y
@ 2025-12-31  0:57 Miguel Ojeda
  2025-12-31  1:44 ` Danilo Krummrich
  0 siblings, 1 reply; 4+ messages in thread
From: Miguel Ojeda @ 2025-12-31  0:57 UTC (permalink / raw)
  To: Greg KH, Sasha Levin
  Cc: Danilo Krummrich, Alexandre Courbot, stable, Nouveau Dev

Hi Greg, Sasha,

Please consider commit ba1b40ed0e34 ("drm: nova: depend on
CONFIG_64BIT") for 6.18.y. It should cherry-pick cleanly.

Without this commit, one can create a config where `CONFIG_DRM_NOVA`
selects `CONFIG_NOVA_CORE` without satisfying its `CONFIG_64BIT`
dependency.

In turn, this means arm32 builds can fail -- Kconfig warns:

    WARNING: unmet direct dependencies detected for NOVA_CORE
      Depends on [n]: HAS_IOMEM [=y] && 64BIT && PCI [=y] && RUST [=y]
&& RUST_FW_LOADER_ABSTRACTIONS [=y]
      Selected by [y]:
      - DRM_NOVA [=y] && HAS_IOMEM [=y] && DRM [=y]=y [=y] && PCI [=y]
&& RUST [=y]

And then the build fails with (among others, see the related commit
5c5a41a75452 ("gpu: nova-core: depend on CONFIG_64BIT") for more):

     error[E0308]: mismatched types
      --> drivers/gpu/nova-core/fb.rs:50:59
       |
    50 |         hal::fb_hal(chipset).write_sysmem_flush_page(bar,
page.dma_handle())?;
       |                              -----------------------
^^^^^^^^^^^^^^^^^ expected `u64`, found `u32`
       |                              |
       |                              arguments to this method are incorrect
       |

Cc'ing Danilo and Alexandre so that they can confirm they agree.

Thanks!

Cheers,
Miguel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: ba1b40ed0e34bab597fd90d4c4e9f7397f878c8f for 6.18.y
  2025-12-31  0:57 ba1b40ed0e34bab597fd90d4c4e9f7397f878c8f for 6.18.y Miguel Ojeda
@ 2025-12-31  1:44 ` Danilo Krummrich
  2025-12-31 20:02   ` John Hubbard
  0 siblings, 1 reply; 4+ messages in thread
From: Danilo Krummrich @ 2025-12-31  1:44 UTC (permalink / raw)
  To: Miguel Ojeda; +Cc: Greg KH, Sasha Levin, Alexandre Courbot, stable, Nouveau Dev

On Wed Dec 31, 2025 at 1:57 AM CET, Miguel Ojeda wrote:
> Cc'ing Danilo and Alexandre so that they can confirm they agree.

Good catch! Greg, Sasha: Please consider this commit for stable.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: ba1b40ed0e34bab597fd90d4c4e9f7397f878c8f for 6.18.y
  2025-12-31  1:44 ` Danilo Krummrich
@ 2025-12-31 20:02   ` John Hubbard
  2026-01-02 12:23     ` Greg KH
  0 siblings, 1 reply; 4+ messages in thread
From: John Hubbard @ 2025-12-31 20:02 UTC (permalink / raw)
  To: Danilo Krummrich, Miguel Ojeda
  Cc: Greg KH, Sasha Levin, Alexandre Courbot, stable, Nouveau Dev

On 12/30/25 5:44 PM, Danilo Krummrich wrote:
> On Wed Dec 31, 2025 at 1:57 AM CET, Miguel Ojeda wrote:
>> Cc'ing Danilo and Alexandre so that they can confirm they agree.
> 
> Good catch! Greg, Sasha: Please consider this commit for stable.

Alex is away, but I also agree with this.

thanks,
-- 
John Hubbard


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: ba1b40ed0e34bab597fd90d4c4e9f7397f878c8f for 6.18.y
  2025-12-31 20:02   ` John Hubbard
@ 2026-01-02 12:23     ` Greg KH
  0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2026-01-02 12:23 UTC (permalink / raw)
  To: John Hubbard
  Cc: Danilo Krummrich, Miguel Ojeda, Sasha Levin, Alexandre Courbot,
	stable, Nouveau Dev

On Wed, Dec 31, 2025 at 12:02:20PM -0800, John Hubbard wrote:
> On 12/30/25 5:44 PM, Danilo Krummrich wrote:
> > On Wed Dec 31, 2025 at 1:57 AM CET, Miguel Ojeda wrote:
> >> Cc'ing Danilo and Alexandre so that they can confirm they agree.
> > 
> > Good catch! Greg, Sasha: Please consider this commit for stable.
> 
> Alex is away, but I also agree with this.

Now queued up, thanks.

greg k-h

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-01-02 12:23 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-31  0:57 ba1b40ed0e34bab597fd90d4c4e9f7397f878c8f for 6.18.y Miguel Ojeda
2025-12-31  1:44 ` Danilo Krummrich
2025-12-31 20:02   ` John Hubbard
2026-01-02 12:23     ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox