From: "Danilo Krummrich" <dakr@kernel.org>
To: "Miguel Ojeda" <miguel.ojeda.sandonis@gmail.com>,
<gregkh@linuxfoundation.org>, <sashal@kernel.org>
Cc: "Marko Turk" <mt@markoturk.info>,
"Dirk Behme" <dirk.behme@gmail.com>, <dirk.behme@de.bosch.com>,
<linux-pci@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<rust-for-linux@vger.kernel.org>, <stable@vger.kernel.org>
Subject: Re: [PATCH 2/2] rust: pci: fix typo in Bar struct's comment
Date: Sun, 04 Jan 2026 15:08:17 +0100 [thread overview]
Message-ID: <DFFV41VPS2MU.3LHXU4UKITD0U@kernel.org> (raw)
In-Reply-To: <CANiq72=t-U8JTH2JZxkQaW7sbYXjWLpkYkuMd_CuzLoJLbEvgQ@mail.gmail.com>
(Cc: Greg, Sasha)
On Sun Jan 4, 2026 at 1:45 PM CET, Miguel Ojeda wrote:
> On Sat, Jan 3, 2026 at 10:16 PM Marko Turk <mt@markoturk.info> wrote:
>>
>> The typo was introduced in the original commit where pci::Bar was added:
>> Fixes: bf9651f84b4e ("rust: pci: implement I/O mappable `pci::Bar`")
>>
>> Should I use that for the Fixes: tag?
>
> I would add both, since it was added in both and thus different set of
> stable releases may need to fix it differently (i.e. before and after
> the move).
In general I prefer to only add a Fixes: tag for the commit that introduced the
issue.
> In this case, from a quick look, one is for the current release, so it
> doesn't need backport, and the other would need a custom one (since
> this commit wouldn't apply) if someone wants to do Option 3.
I could be wrong, but I think in trivial cases (such as code moves) the stable
team does derive custom commits themselves.
@Greg, Sasha: Is this something you prefer to do or is it something you just do
because it's easier / quicker than to get back and ask for a custom commit?
Again, I could also remember this wrongly, but I think I just recently reviewed
such a commit from Sasha. :)
>> Should I do that in the same commit?
That seems reasonable in this case, please do so.
next parent reply other threads:[~2026-01-04 14:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260103143119.96095-1-mt@markoturk.info>
[not found] ` <20260103143119.96095-2-mt@markoturk.info>
[not found] ` <DFF23OTZRIDS.2PZIV7D8AHWFA@kernel.org>
[not found] ` <84cc5699-f9ab-42b3-a1ea-15bf9bd80d19@gmail.com>
[not found] ` <aVmHGBop5OPlVVBa@vps.markoturk.info>
[not found] ` <CANiq72=t-U8JTH2JZxkQaW7sbYXjWLpkYkuMd_CuzLoJLbEvgQ@mail.gmail.com>
2026-01-04 14:08 ` Danilo Krummrich [this message]
2026-01-04 18:30 ` [PATCH 2/2] rust: pci: fix typo in Bar struct's comment Miguel Ojeda
2026-01-05 6:25 ` Greg KH
2026-01-05 10:39 ` Miguel Ojeda
2026-01-05 12:38 ` Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DFFV41VPS2MU.3LHXU4UKITD0U@kernel.org \
--to=dakr@kernel.org \
--cc=dirk.behme@de.bosch.com \
--cc=dirk.behme@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=mt@markoturk.info \
--cc=rust-for-linux@vger.kernel.org \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox