* [PATCH] platform/x86: dell-wmi: Add audio/mic mute key codes
@ 2026-02-02 4:37 Kurt Borja
2026-02-02 8:12 ` Pali Rohár
2026-02-02 14:17 ` Mario Limonciello
0 siblings, 2 replies; 7+ messages in thread
From: Kurt Borja @ 2026-02-02 4:37 UTC (permalink / raw)
To: Matthew Garrett, Pali Rohár, Hans de Goede,
Ilpo Järvinen
Cc: platform-driver-x86, linux-kernel, stable, Olexa Bilaniuk,
Kurt Borja
Add audio/mic mute key codes found in some Alienware devices.
Cc: stable@vger.kernel.org
Tested-by: Olexa Bilaniuk <obilaniu@gmail.com>
Suggested-by: Olexa Bilaniuk <obilaniu@gmail.com>
Signed-off-by: Kurt Borja <kuurtb@gmail.com>
---
drivers/platform/x86/dell/dell-wmi-base.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/platform/x86/dell/dell-wmi-base.c b/drivers/platform/x86/dell/dell-wmi-base.c
index 28076929d6af..62cf28d1fe19 100644
--- a/drivers/platform/x86/dell/dell-wmi-base.c
+++ b/drivers/platform/x86/dell/dell-wmi-base.c
@@ -86,6 +86,9 @@ static const struct key_entry dell_wmi_keymap_type_0000[] = {
/* Meta key unlock */
{ KE_IGNORE, 0xe001, { KEY_RIGHTMETA } },
+ { KE_KEY, 0x0109, { KEY_MUTE } },
+ { KE_KEY, 0x0150, { KEY_MICMUTE } },
+
/* Key code is followed by brightness level */
{ KE_KEY, 0xe005, { KEY_BRIGHTNESSDOWN } },
{ KE_KEY, 0xe006, { KEY_BRIGHTNESSUP } },
---
base-commit: 008bec8ffe6e7746588d1e12c5b3865fa478fc91
change-id: 20260126-mute-keys-7f8a27cd317f
--
~ Kurt
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] platform/x86: dell-wmi: Add audio/mic mute key codes
2026-02-02 4:37 [PATCH] platform/x86: dell-wmi: Add audio/mic mute key codes Kurt Borja
@ 2026-02-02 8:12 ` Pali Rohár
2026-02-02 17:34 ` Kurt Borja
2026-02-02 14:17 ` Mario Limonciello
1 sibling, 1 reply; 7+ messages in thread
From: Pali Rohár @ 2026-02-02 8:12 UTC (permalink / raw)
To: Kurt Borja
Cc: Matthew Garrett, Hans de Goede, Ilpo Järvinen,
platform-driver-x86, linux-kernel, stable, Olexa Bilaniuk
On Sunday 01 February 2026 23:37:37 Kurt Borja wrote:
> Add audio/mic mute key codes found in some Alienware devices.
>
> Cc: stable@vger.kernel.org
> Tested-by: Olexa Bilaniuk <obilaniu@gmail.com>
> Suggested-by: Olexa Bilaniuk <obilaniu@gmail.com>
> Signed-off-by: Kurt Borja <kuurtb@gmail.com>
> ---
> drivers/platform/x86/dell/dell-wmi-base.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/platform/x86/dell/dell-wmi-base.c b/drivers/platform/x86/dell/dell-wmi-base.c
> index 28076929d6af..62cf28d1fe19 100644
> --- a/drivers/platform/x86/dell/dell-wmi-base.c
> +++ b/drivers/platform/x86/dell/dell-wmi-base.c
> @@ -86,6 +86,9 @@ static const struct key_entry dell_wmi_keymap_type_0000[] = {
> /* Meta key unlock */
> { KE_IGNORE, 0xe001, { KEY_RIGHTMETA } },
>
> + { KE_KEY, 0x0109, { KEY_MUTE } },
> + { KE_KEY, 0x0150, { KEY_MICMUTE } },
Hello, please keep codes in the array sorted.
> +
> /* Key code is followed by brightness level */
> { KE_KEY, 0xe005, { KEY_BRIGHTNESSDOWN } },
> { KE_KEY, 0xe006, { KEY_BRIGHTNESSUP } },
>
> ---
> base-commit: 008bec8ffe6e7746588d1e12c5b3865fa478fc91
> change-id: 20260126-mute-keys-7f8a27cd317f
>
> --
> ~ Kurt
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] platform/x86: dell-wmi: Add audio/mic mute key codes
2026-02-02 8:12 ` Pali Rohár
@ 2026-02-02 17:34 ` Kurt Borja
2026-02-02 17:43 ` Pali Rohár
0 siblings, 1 reply; 7+ messages in thread
From: Kurt Borja @ 2026-02-02 17:34 UTC (permalink / raw)
To: Pali Rohár, Kurt Borja
Cc: Matthew Garrett, Hans de Goede, Ilpo Järvinen,
platform-driver-x86, linux-kernel, stable, Olexa Bilaniuk
On Mon Feb 2, 2026 at 3:12 AM -05, Pali Rohár wrote:
> On Sunday 01 February 2026 23:37:37 Kurt Borja wrote:
>> Add audio/mic mute key codes found in some Alienware devices.
>>
>> Cc: stable@vger.kernel.org
>> Tested-by: Olexa Bilaniuk <obilaniu@gmail.com>
>> Suggested-by: Olexa Bilaniuk <obilaniu@gmail.com>
>> Signed-off-by: Kurt Borja <kuurtb@gmail.com>
>> ---
>> drivers/platform/x86/dell/dell-wmi-base.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/platform/x86/dell/dell-wmi-base.c b/drivers/platform/x86/dell/dell-wmi-base.c
>> index 28076929d6af..62cf28d1fe19 100644
>> --- a/drivers/platform/x86/dell/dell-wmi-base.c
>> +++ b/drivers/platform/x86/dell/dell-wmi-base.c
>> @@ -86,6 +86,9 @@ static const struct key_entry dell_wmi_keymap_type_0000[] = {
>> /* Meta key unlock */
>> { KE_IGNORE, 0xe001, { KEY_RIGHTMETA } },
>>
>> + { KE_KEY, 0x0109, { KEY_MUTE } },
>> + { KE_KEY, 0x0150, { KEY_MICMUTE } },
>
> Hello, please keep codes in the array sorted.
Hi Pali,
I thought I sorted it... I'll fix it, thanks!
>
>> +
>> /* Key code is followed by brightness level */
>> { KE_KEY, 0xe005, { KEY_BRIGHTNESSDOWN } },
>> { KE_KEY, 0xe006, { KEY_BRIGHTNESSUP } },
>>
>> ---
>> base-commit: 008bec8ffe6e7746588d1e12c5b3865fa478fc91
>> change-id: 20260126-mute-keys-7f8a27cd317f
>>
>> --
>> ~ Kurt
>>
--
Thanks,
~ Kurt
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] platform/x86: dell-wmi: Add audio/mic mute key codes
2026-02-02 17:34 ` Kurt Borja
@ 2026-02-02 17:43 ` Pali Rohár
2026-02-03 2:40 ` Kurt Borja
0 siblings, 1 reply; 7+ messages in thread
From: Pali Rohár @ 2026-02-02 17:43 UTC (permalink / raw)
To: Kurt Borja
Cc: Matthew Garrett, Hans de Goede, Ilpo Järvinen,
platform-driver-x86, linux-kernel, stable, Olexa Bilaniuk
On Monday 02 February 2026 12:34:19 Kurt Borja wrote:
> On Mon Feb 2, 2026 at 3:12 AM -05, Pali Rohár wrote:
> > On Sunday 01 February 2026 23:37:37 Kurt Borja wrote:
> >> Add audio/mic mute key codes found in some Alienware devices.
> >>
> >> Cc: stable@vger.kernel.org
> >> Tested-by: Olexa Bilaniuk <obilaniu@gmail.com>
> >> Suggested-by: Olexa Bilaniuk <obilaniu@gmail.com>
> >> Signed-off-by: Kurt Borja <kuurtb@gmail.com>
> >> ---
> >> drivers/platform/x86/dell/dell-wmi-base.c | 3 +++
> >> 1 file changed, 3 insertions(+)
> >>
> >> diff --git a/drivers/platform/x86/dell/dell-wmi-base.c b/drivers/platform/x86/dell/dell-wmi-base.c
> >> index 28076929d6af..62cf28d1fe19 100644
> >> --- a/drivers/platform/x86/dell/dell-wmi-base.c
> >> +++ b/drivers/platform/x86/dell/dell-wmi-base.c
> >> @@ -86,6 +86,9 @@ static const struct key_entry dell_wmi_keymap_type_0000[] = {
> >> /* Meta key unlock */
> >> { KE_IGNORE, 0xe001, { KEY_RIGHTMETA } },
> >>
> >> + { KE_KEY, 0x0109, { KEY_MUTE } },
> >> + { KE_KEY, 0x0150, { KEY_MICMUTE } },
> >
> > Hello, please keep codes in the array sorted.
>
> Hi Pali,
>
> I thought I sorted it... I'll fix it, thanks!
Before is value 0xe001 and your new values are 0x01xx. Most of values
are 0xeXXX, so it is quite unusual that Dell allocated values with
different pattern.
Also, could you please include into commit message for which Alienware
devices is change needed? It would help to detect devices which will be
fixed by your change.
And please add some comment into source file above those two new codes
for which are needed, in similar way how we have commented/documented
other key codes.
> >
> >> +
> >> /* Key code is followed by brightness level */
> >> { KE_KEY, 0xe005, { KEY_BRIGHTNESSDOWN } },
> >> { KE_KEY, 0xe006, { KEY_BRIGHTNESSUP } },
> >>
> >> ---
> >> base-commit: 008bec8ffe6e7746588d1e12c5b3865fa478fc91
> >> change-id: 20260126-mute-keys-7f8a27cd317f
> >>
> >> --
> >> ~ Kurt
> >>
>
> --
> Thanks,
> ~ Kurt
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] platform/x86: dell-wmi: Add audio/mic mute key codes
2026-02-02 17:43 ` Pali Rohár
@ 2026-02-03 2:40 ` Kurt Borja
0 siblings, 0 replies; 7+ messages in thread
From: Kurt Borja @ 2026-02-03 2:40 UTC (permalink / raw)
To: Pali Rohár, Kurt Borja
Cc: Matthew Garrett, Hans de Goede, Ilpo Järvinen,
platform-driver-x86, linux-kernel, stable, Olexa Bilaniuk
On Mon Feb 2, 2026 at 12:43 PM -05, Pali Rohár wrote:
> On Monday 02 February 2026 12:34:19 Kurt Borja wrote:
>> On Mon Feb 2, 2026 at 3:12 AM -05, Pali Rohár wrote:
>> > On Sunday 01 February 2026 23:37:37 Kurt Borja wrote:
>> >> Add audio/mic mute key codes found in some Alienware devices.
>> >>
>> >> Cc: stable@vger.kernel.org
>> >> Tested-by: Olexa Bilaniuk <obilaniu@gmail.com>
>> >> Suggested-by: Olexa Bilaniuk <obilaniu@gmail.com>
>> >> Signed-off-by: Kurt Borja <kuurtb@gmail.com>
>> >> ---
>> >> drivers/platform/x86/dell/dell-wmi-base.c | 3 +++
>> >> 1 file changed, 3 insertions(+)
>> >>
>> >> diff --git a/drivers/platform/x86/dell/dell-wmi-base.c b/drivers/platform/x86/dell/dell-wmi-base.c
>> >> index 28076929d6af..62cf28d1fe19 100644
>> >> --- a/drivers/platform/x86/dell/dell-wmi-base.c
>> >> +++ b/drivers/platform/x86/dell/dell-wmi-base.c
>> >> @@ -86,6 +86,9 @@ static const struct key_entry dell_wmi_keymap_type_0000[] = {
>> >> /* Meta key unlock */
>> >> { KE_IGNORE, 0xe001, { KEY_RIGHTMETA } },
>> >>
>> >> + { KE_KEY, 0x0109, { KEY_MUTE } },
>> >> + { KE_KEY, 0x0150, { KEY_MICMUTE } },
>> >
>> > Hello, please keep codes in the array sorted.
>>
>> Hi Pali,
>>
>> I thought I sorted it... I'll fix it, thanks!
>
> Before is value 0xe001 and your new values are 0x01xx. Most of values
> are 0xeXXX, so it is quite unusual that Dell allocated values with
> different pattern.
It is a bit unusual but it corresponds with the user report
dell_wmi: Unknown key with type 0x0000 and code 0x0109 pressed
dell_wmi: Unknown key with type 0x0000 and code 0x0150 pressed
and I also checked the acpidump.
>
> Also, could you please include into commit message for which Alienware
> devices is change needed? It would help to detect devices which will be
> fixed by your change.
Sure, the model is Alienware m18 r1 AMD.
I said "some" in the commit message because it's very likely other
Alienware models also use these codes.
>
> And please add some comment into source file above those two new codes
> for which are needed, in similar way how we have commented/documented
> other key codes.
Ack.
--
Thanks,
~ Kurt
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] platform/x86: dell-wmi: Add audio/mic mute key codes
2026-02-02 4:37 [PATCH] platform/x86: dell-wmi: Add audio/mic mute key codes Kurt Borja
2026-02-02 8:12 ` Pali Rohár
@ 2026-02-02 14:17 ` Mario Limonciello
2026-02-02 17:35 ` Kurt Borja
1 sibling, 1 reply; 7+ messages in thread
From: Mario Limonciello @ 2026-02-02 14:17 UTC (permalink / raw)
To: Kurt Borja, Matthew Garrett, Pali Rohár, Hans de Goede,
Ilpo Järvinen
Cc: platform-driver-x86, linux-kernel, stable, Olexa Bilaniuk,
Dell.Client.Kernel
On 2/1/26 10:37 PM, Kurt Borja wrote:
> Add audio/mic mute key codes found in some Alienware devices.
>
> Cc: stable@vger.kernel.org
> Tested-by: Olexa Bilaniuk <obilaniu@gmail.com>
> Suggested-by: Olexa Bilaniuk <obilaniu@gmail.com>
> Signed-off-by: Kurt Borja <kuurtb@gmail.com>
> ---
> drivers/platform/x86/dell/dell-wmi-base.c | 3 +++
> 1 file changed, 3 insertions(+)
Make sure that you include Dell.Client.Kernel@dell.com in case they have
any comments.
I added them to CC.
>
> diff --git a/drivers/platform/x86/dell/dell-wmi-base.c b/drivers/platform/x86/dell/dell-wmi-base.c
> index 28076929d6af..62cf28d1fe19 100644
> --- a/drivers/platform/x86/dell/dell-wmi-base.c
> +++ b/drivers/platform/x86/dell/dell-wmi-base.c
> @@ -86,6 +86,9 @@ static const struct key_entry dell_wmi_keymap_type_0000[] = {
> /* Meta key unlock */
> { KE_IGNORE, 0xe001, { KEY_RIGHTMETA } },
>
> + { KE_KEY, 0x0109, { KEY_MUTE } },
> + { KE_KEY, 0x0150, { KEY_MICMUTE } },
> +
> /* Key code is followed by brightness level */
> { KE_KEY, 0xe005, { KEY_BRIGHTNESSDOWN } },
> { KE_KEY, 0xe006, { KEY_BRIGHTNESSUP } },
>
> ---
> base-commit: 008bec8ffe6e7746588d1e12c5b3865fa478fc91
> change-id: 20260126-mute-keys-7f8a27cd317f
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] platform/x86: dell-wmi: Add audio/mic mute key codes
2026-02-02 14:17 ` Mario Limonciello
@ 2026-02-02 17:35 ` Kurt Borja
0 siblings, 0 replies; 7+ messages in thread
From: Kurt Borja @ 2026-02-02 17:35 UTC (permalink / raw)
To: Mario Limonciello, Kurt Borja, Matthew Garrett, Pali Rohár,
Hans de Goede, Ilpo Järvinen
Cc: platform-driver-x86, linux-kernel, stable, Olexa Bilaniuk,
Dell.Client.Kernel
On Mon Feb 2, 2026 at 9:17 AM -05, Mario Limonciello wrote:
> On 2/1/26 10:37 PM, Kurt Borja wrote:
>> Add audio/mic mute key codes found in some Alienware devices.
>>
>> Cc: stable@vger.kernel.org
>> Tested-by: Olexa Bilaniuk <obilaniu@gmail.com>
>> Suggested-by: Olexa Bilaniuk <obilaniu@gmail.com>
>> Signed-off-by: Kurt Borja <kuurtb@gmail.com>
>> ---
>> drivers/platform/x86/dell/dell-wmi-base.c | 3 +++
>> 1 file changed, 3 insertions(+)
>
> Make sure that you include Dell.Client.Kernel@dell.com in case they have
> any comments.
>
> I added them to CC.
Hi Mario,
Thanks, I'll add it.
--
Thanks,
~ Kurt
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2026-02-03 2:40 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-02 4:37 [PATCH] platform/x86: dell-wmi: Add audio/mic mute key codes Kurt Borja
2026-02-02 8:12 ` Pali Rohár
2026-02-02 17:34 ` Kurt Borja
2026-02-02 17:43 ` Pali Rohár
2026-02-03 2:40 ` Kurt Borja
2026-02-02 14:17 ` Mario Limonciello
2026-02-02 17:35 ` Kurt Borja
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox