public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: "Danilo Krummrich" <dakr@kernel.org>
To: "Greg KH" <gregkh@linuxfoundation.org>
Cc: "Bruno Prémont" <bonbons@sysophe.eu>,
	dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
	"Lyude Paul" <lyude@redhat.com>,
	stable@vger.kernel.org, "Dave Airlie" <airlied@redhat.com>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Simona Vetter" <simona@ffwll.ch>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"Maxime Ripard" <mripard@kernel.org>
Subject: Re: NV04, 6.18.8 crashes on NULL pointer dereference
Date: Tue, 03 Feb 2026 16:37:06 +0100	[thread overview]
Message-ID: <DG5FSE0B706U.1VFSJLK4DOD5C@kernel.org> (raw)
In-Reply-To: <2026020353-running-unhelpful-fbd2@gregkh>

On Tue Feb 3, 2026 at 3:38 PM CET, Greg KH wrote:
> On Sun, Feb 01, 2026 at 11:14:51PM +0100, Bruno Prémont wrote:
>> Bisect completed.
>> 
>> The offending patch is:
>> commit 448a2071a843831fe5fa71545cbfa7e15ee8966d (HEAD)
>> Author: Lyude Paul <lyude@redhat.com>
>> Date:   Wed Jan 21 14:13:10 2026 -0500
>> 
>>     drm/nouveau/disp: Set drm_mode_config_funcs.atomic_(check|commit)
>>     
>>     commit 604826acb3f53c6648a7ee99a3914ead680ab7fb upstream.
>>     
>>     Apparently we never actually filled these in, despite the fact that we do
>>     in fact technically support atomic modesetting.
>>     
>>     Since not having these filled in causes us to potentially forget to disable
>>     fbdev and friends during suspend/resume, let's fix it.
>>     
>>     Signed-off-by: Lyude Paul <lyude@redhat.com>
>>     Cc: stable@vger.kernel.org
>>     Reviewed-by: Dave Airlie <airlied@redhat.com>
>>     Link: https://patch.msgid.link/20260121191320.210342-1-lyude@redhat.com
>>     Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> 
>>  drivers/gpu/drm/nouveau/nouveau_display.c | 2 ++
>>  1 file changed, 2 insertions(+)
>> 
>> 
>> It landed in 6.18.8. Seems like not all chip generations are ready for
>> atomic modesetting.
>
> Is this also a problem in 6.19-rc?

I did not test it, but a different mail [1] suggests that John did reproduce
this in 6.19-rc7 too.

I've already picked up a revert [2], which should be in linux-next and should
soon be in Linus' tree as well.

[1] https://lore.kernel.org/all/87h5s34d36.fsf@jogness.linutronix.de/
[2] https://patch.msgid.link/20260130113230.2311221-1-john.ogness@linutronix.de

      reply	other threads:[~2026-02-03 15:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20260201185705.0c5364f1@hemera.lan.sysophe.eu>
2026-02-01 22:14 ` NV04, 6.18.8 crashes on NULL pointer dereference Bruno Prémont
2026-02-03 14:38   ` Greg KH
2026-02-03 15:37     ` Danilo Krummrich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DG5FSE0B706U.1VFSJLK4DOD5C@kernel.org \
    --to=dakr@kernel.org \
    --cc=airlied@redhat.com \
    --cc=bonbons@sysophe.eu \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=lyude@redhat.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=nouveau@lists.freedesktop.org \
    --cc=simona@ffwll.ch \
    --cc=stable@vger.kernel.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox