public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: "Gary Guo" <gary@garyguo.net>
To: "Miguel Ojeda" <ojeda@kernel.org>, <stable@vger.kernel.org>,
	"Benno Lossin" <lossin@kernel.org>, "Gary Guo" <gary@garyguo.net>
Cc: <rust-for-linux@vger.kernel.org>
Subject: Re: [PATCH 6.12.y] rust: init: fix `clippy::undocumented_unsafe_blocks` warnings
Date: Mon, 27 Apr 2026 14:05:38 +0100	[thread overview]
Message-ID: <DI3YJMZXOAE2.1F2MWADRYBAKO@garyguo.net> (raw)
In-Reply-To: <20260426232113.279040-1-ojeda@kernel.org>

On Mon Apr 27, 2026 at 12:21 AM BST, Miguel Ojeda wrote:
> The stable backport in commit acc105db0826 ("rust: pin-init:
> add references to previously initialized fields") introduced some
> `clippy::undocumented_unsafe_blocks` warnings [1], e.g.
> 
>     error: unsafe block missing a safety comment
>         --> rust/kernel/init/macros.rs:1015:25
> 
> As well as:
> 
>     --> rust/kernel/init/macros.rs:1243:45
>     --> rust/kernel/init/macros.rs:1286:22
>     --> rust/kernel/init/macros.rs:1374:45
> 
> After discussing it with Benno and Gary, we decided to clean the build
> log by doing a minimal targeted stable commit.
> 
> Thus, depending on the case:
> 
>   - Reorder the attributes so that the existing `// SAFETY:` comments
>     may be seen by Clippy.
> 
>   - Add a placeholder `// SAFETY: TODO.` comment.
> 
> Cc: Benno Lossin <lossin@kernel.org>
> Cc: Gary Guo <gary@garyguo.net>
> Fixes: acc105db0826 ("rust: pin-init: add references to previously initialized fields")
> Link: https://lore.kernel.org/stable/20260421111111.57059-1-ojeda@kernel.org/ [1]
> Signed-off-by: Miguel Ojeda <ojeda@kernel.org>

Acked-by: Gary Guo <gary@garyguo.net>

> ---
> Greg/Sasha: please let Benno & Gary Acked-by the patch before picking it
> up -- thanks!
> 
>  rust/kernel/init/macros.rs | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)


      reply	other threads:[~2026-04-27 13:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-26 23:21 [PATCH 6.12.y] rust: init: fix `clippy::undocumented_unsafe_blocks` warnings Miguel Ojeda
2026-04-27 13:05 ` Gary Guo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DI3YJMZXOAE2.1F2MWADRYBAKO@garyguo.net \
    --to=gary@garyguo.net \
    --cc=lossin@kernel.org \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox