From: "Danilo Krummrich" <dakr@kernel.org>
To: "Bart Van Assche" <bvanassche@acm.org>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
<driver-core@lists.linux.dev>,
"Luis Chamberlain" <mcgrof@kernel.org>,
"Petr Pavlu" <petr.pavlu@suse.com>,
"Daniel Gomez" <da.gomez@kernel.org>,
"Sami Tolvanen" <samitolvanen@google.com>,
"Aaron Tomlin" <atomlin@atomlin.com>,
"Igor Pylypiv" <ipylypiv@google.com>,
"Chung-Kai Mei" <chungkai@google.com>,
"Luis R. Rodriguez" <mcgrof@suse.com>, <stable@vger.kernel.org>
Subject: Re: [PATCH] drivers: base: Set mod->async_probe_requested if needed
Date: Wed, 29 Apr 2026 23:41:38 +0200 [thread overview]
Message-ID: <DI5YRSXD3NAC.27M8UD3I3VY3M@kernel.org> (raw)
In-Reply-To: <2fc4a2af-a4bb-4797-87eb-e95b835aa673@acm.org>
(Cc: Luis)
On Tue Apr 28, 2026 at 9:39 PM CEST, Bart Van Assche wrote:
> On 4/28/26 11:22 AM, Danilo Krummrich wrote:
>> What if userspace did explicitly pass async_probe=0?
>
> Does this mean that what the user has configured should take precedence,
> as in the untested patch below?
Yes, but my concern actually goes beyond that (sorry for not expressing this
properly right away).
I think the whole reason the async_probe module parameter exists in the first
place is because userspace may rely on the devices being handled by the module
to be available directly after returning from the syscall.
Even worse, with this patch we would make this user facing behavior dependent on
an implementation detail of the driver, i.e. whether it chooses to opt into
PROBE_PREFER_ASYNCHRONOUS.
prev parent reply other threads:[~2026-04-29 21:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-07 16:05 [PATCH] drivers: base: Set mod->async_probe_requested if needed Bart Van Assche
2026-04-28 18:22 ` Danilo Krummrich
2026-04-28 19:39 ` Bart Van Assche
2026-04-29 21:41 ` Danilo Krummrich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DI5YRSXD3NAC.27M8UD3I3VY3M@kernel.org \
--to=dakr@kernel.org \
--cc=atomlin@atomlin.com \
--cc=bvanassche@acm.org \
--cc=chungkai@google.com \
--cc=da.gomez@kernel.org \
--cc=driver-core@lists.linux.dev \
--cc=gregkh@linuxfoundation.org \
--cc=ipylypiv@google.com \
--cc=mcgrof@kernel.org \
--cc=mcgrof@suse.com \
--cc=petr.pavlu@suse.com \
--cc=rafael@kernel.org \
--cc=samitolvanen@google.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox