From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from PH0PR06CU001.outbound.protection.outlook.com (mail-westus3azon11011025.outbound.protection.outlook.com [40.107.208.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 08F1337C912 for ; Wed, 8 Jul 2026 01:54:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.208.25 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783475670; cv=fail; b=bL6Q6q+PkzNUa5Ko4m0b+oKRQjioMrpXwstAm+sUlAMkOj0rTwc6ZG5kBwGfF/aGwF6BQDgT50Wj9ccN4CNfTpoPDbr49p1pKbsEKZJRMExPIUGcy979P479QYbWPSRc9HuYR1YhBfxAdxweDRJUb7PBFC1oa06kaR+s2IdQgqM= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783475670; c=relaxed/simple; bh=JYTvmnqtUN7WXfSDcKTF7duqiCYkZvE2Smboj3uy7eo=; h=Content-Type:Date:Message-Id:From:Subject:Cc:To:References: In-Reply-To:MIME-Version; b=JJcwxxVzN+2IDRqAp5+2yOOZEz9odOyGkX5RGFoLJb19Chm/rll/xBMMMWWcQzypQm1ZNpmd9zfRKYn8wkEBJaz/e13/iQoY6Mw9PytC92+2uj8lUr3CS8FhiVw11mbhmHQ394Hnbr4iAxxNnnc0W9An5iYuJTG1Itu/y3ohwFQ= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=dE6CKJCk; arc=fail smtp.client-ip=40.107.208.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="dE6CKJCk" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=v+lXu7I9l0uEPulmjYRckvgBJjChY8jTCo0ifV+oqbo06yY7bGid29txkoaKgyiP0t3A6t7ascHQF5dKvcegn+Bu+L2vVdZBZ+h+4Fw6nqH/mYwsQmU21W8oRFfp66YXm8bcKzPz1Ji0+MHe3yZV4gojLGCK7L+1VPXmzNQvJ/d0CpyMgqV+Y0K0EVEkSbY5wdb+uFp2r3Mk1K+X5Z6eVbG2TeVL8zlhl0bEKsu3Ft32nAt/CPn+CUSVDpbJsGmodOq24taDlAC8OrAU2bRmCxMrZNFHEN4GfAWikiKsxdkkIAUgCxKtCGmXELC/3iM9Io6QXWpY/EfxQQCZl1BJaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PdiB+ZsLgLotNLWidn7YTFulb4NHIYexj5JpCnyBalk=; b=WVc/Xwg3rcER9UWMKNFDTf6LGJfOygXVg4l7SiIWLRpSh21G4dRJKPAj3LlXzXMCk8bcwzTyP7opW9TRs+kxtTIEPyuHqTh/Wn2N8W3htyHzJbhE1/bGq4QEPcEh+/QcOspRPTnoxE38mLa+GYt70uTFNr8Oa6aJ3adC3ywCi6ZLl6D4aCpcWdA9B3bsouMnex0MeXxGU6T0s8jIenKJOJRjoFIqMizuk3XObNvoc+9K4MB0utz9fI0a+ErQNOgwIpDAz4/nKTjnVqC5G1MmEFu/x9duiW5thfFKtrd/dwUjG+GRhEjZFV0O/3Zd3YBtyawbp1hxSt4LPMSC55eLDA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PdiB+ZsLgLotNLWidn7YTFulb4NHIYexj5JpCnyBalk=; b=dE6CKJCkFo3tbJ/9NQUnuu0HRk7/H9PiCP88vO85hoEP9XtfQQkLLt9P1RvHPqGxbqbJufLOcym03ywR2Aik3KXWpNA8viN4Lci5s+XwfxNiyPWdJPGFLpcq9ha6HG5zc7JZY9UoeGB1P+s9KgWFLeZPSm0pDma+EslgpJse52Bu4b+zpOwwzk5RO62H9KxHte1Q3gIXZL24vDJpme9S5eRHfiv+YnVSHSUHs4KPxB4J8T0W81ONg8XRHio2t/UDNemStZsOaww2T493pvlnsJLhyhwfEnLtQq9YK2CN3Wn0xXz/0pnBCp9WzpS+f1iE65XlueJBnlv3yHFHZXYVrg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from IA0PR12MB8374.namprd12.prod.outlook.com (2603:10b6:208:40e::7) by SJ1PR12MB6290.namprd12.prod.outlook.com (2603:10b6:a03:457::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.10; Wed, 8 Jul 2026 01:54:22 +0000 Received: from IA0PR12MB8374.namprd12.prod.outlook.com ([fe80::d85f:4c87:ae84:3f16]) by IA0PR12MB8374.namprd12.prod.outlook.com ([fe80::d85f:4c87:ae84:3f16%5]) with mapi id 15.21.0181.009; Wed, 8 Jul 2026 01:54:22 +0000 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 07 Jul 2026 21:53:46 -0400 Message-Id: From: "Zi Yan" Subject: Re: [PATCH v2] mm: migrate_device: fix pte_pfn/pte_dirty called on non-present PTE Cc: "Matthew Brost" , "Joshua Hahn" , "Rakie Kim" , "Byungchul Park" , "Gregory Price" , "Ying Huang" , "Alistair Popple" , , To: "Kefeng Wang" , "Andrew Morton" , "David Hildenbrand" X-Mailer: aerc 0.21.0 References: <20260708003955.4024340-1-wangkefeng.wang@huawei.com> In-Reply-To: <20260708003955.4024340-1-wangkefeng.wang@huawei.com> X-ClientProxiedBy: BLAPR03CA0108.namprd03.prod.outlook.com (2603:10b6:208:32a::23) To IA0PR12MB8374.namprd12.prod.outlook.com (2603:10b6:208:40e::7) Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA0PR12MB8374:EE_|SJ1PR12MB6290:EE_ X-MS-Office365-Filtering-Correlation-Id: a66dac35-db97-4224-d3c5-08dedc93d48d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|23010399003|376014|7416014|22082099003|18002099003|6133799003|5023799004|56012099006|11063799006; X-Microsoft-Antispam-Message-Info: zaO+Zi0KeCsmH0t2CV+9yKY3VStMKPh9aKo8GfobSdgcCgjIcgxodqA3zS96S7acdKk4oOFYdl8M3oygXOpusNtWUPCLedRLPcNebEC4yZ4ShzDDbLQBX/bmYZqZKBBaems1QmmccTry0IrgFX7HeHjmqsn5szquWVk2w1O93xuqE+P9tvBJQR9lImmbss7fYlYY+Ali6myaExBUXxgvKtTsZzHukUaIRDrJUcPzW51FBZn57laJnAqrn4XCrFMz3dxVogkAZ/FOjz2v2JFrfs71AKc414gLgL1+kbdtKaQuCuGQY/vL54As5ZhUn1292uvqEQ52+hc7ID2rhmd8e7YP3IfL0ZrrGxRm7lljBm0T+i1zQorASvljgfG+HFLFCuIE7OzqDF78tPoQElsIid6eDRjwOMIeakY7iMmH/LLRD3EuGyHB13DhbSQcr45q7CImhoeHi5yAg/MH64ebsDo1FFO1IJIiXVP4JCgxp0kyvV051b0s1x+JKnYtg3sKs53X0K6VHfO6jPU4khXh2BbMZ5Bu8E/qSULzMwqOqVCmHHpejTh9eoAZAj7viUx/QbMbqkwlK/9H7ai7WPKX3Xuax8CJ8lpMBlzGRLWZ+BWRy9x+OKGgymna6Isq5W5idOQMQpENvz5HeAKsu7tigBn0Tna5i7jL34FzJJ99lu0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA0PR12MB8374.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(23010399003)(376014)(7416014)(22082099003)(18002099003)(6133799003)(5023799004)(56012099006)(11063799006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WkhWVGwxT09Rb00rdG0zZGdmdlRGRzVjQk9lOW00L1NWRDBZcVJYcElkL1cy?= =?utf-8?B?Z0dYYjJKT3ZTa1o5dUpXMFE3cS9mK1lJck00NXRHaXhla3NuU3FHTWRYeDBR?= =?utf-8?B?OHlTNGliKzRkUnFSdUptdytxWTl0YVNLN2J2YjhsVldvRnB3TElDZUVoMlIy?= =?utf-8?B?QXBNVzdRcUliODFlM3lDQ1JmQk1ULzlnNHFOVXQ2SjhGZEFLTFJQWDR6cjJ2?= =?utf-8?B?LzMrYnlPRFphTytaZkxKaURmbkpXVW41WFp6eWxja01uZVRpcnlFaTh3NjFC?= =?utf-8?B?QWtESThxeVRrZTY4amh2SE5qL1NPa0RDbG5RTlcxeHJUNkR4aWx5SlhSZkNZ?= =?utf-8?B?NVE5bWhJbUxIR1NTdElLVlViTUdUcEljVjI4ZmVYb3NYVjVjMExGUHMxUkJr?= =?utf-8?B?T2ZNYkNQaHVNUlk1aDF2Zjk0SUltbWtnVDVraThxZjlnTFpsUzdxanRNaGsy?= =?utf-8?B?S1hhdmZxcW5qU0xteEtFNDlYUnNvaTdkeDE3VkZUVVZLY1Q0cWpZUUxpQ0Fp?= =?utf-8?B?YkUvZHRkZUhyUGFZUWtPdWJjTXBiRTlPTU9jb1BMNVYvM1RNbVZVK2s4L21C?= =?utf-8?B?Q3A1ZlQxRDBqZ3JabEZSS1A1Q1daQkR1bnVyWC9pS1pzRktsdlFjU2w0NnVO?= =?utf-8?B?elVzMG5Gd2hIOHVlS2E5TE4vdXlBS2hKTEZFOVc2c2VlNjlBbU9qWWlFVHRH?= =?utf-8?B?ZVFLM3FCWUxneTl1d280cW0wY0g5dksxQ1dIeXEyYVZJSmF4MWo1QUVhNnhC?= =?utf-8?B?LzlHU21pdzVTcitBTkt5N0NQZU9yb1JFaEVMMTFtUVNROVFyUUc1RExrUHNK?= =?utf-8?B?akRsOHFSZ3hHak1ic1VXSzRCUnI0T2dlSFhtRGZsWGFEMmVzSStkNDVhY2ly?= =?utf-8?B?T0c0cEpaQ3RoTVpxSVpZaUdzWXNIR1dvaHpCWWxNWkI1ZWtOVUNkeXluREF4?= =?utf-8?B?TVE0cFpJRWsxaTdXQ3NLZmcyYXN0Ry92dStLa091S1crdnhLQXNRbFpGc2ps?= =?utf-8?B?TXVJV0c0UDN4NVZyM20zc3lnVWdLN0lNYm9OMjIvNXlBUE9rOWYyTWYyK2lj?= =?utf-8?B?cnQrVVAyaHNOOWRGREZXZnJWLzV5Q2ZXLzg5WStTZWpIMGFydDJmNVVkT3p2?= =?utf-8?B?eGFHYW8xeFVya0t5RG1IdW5pVFhUeHRpN2FGaDBhZkZseGwzVW5VQmptNXFD?= =?utf-8?B?MHlyd2FNaEtDYXNCT1lZRityaEhyMGNzaklBa0tqRm96R0V1M2EzV3ZJbnFJ?= =?utf-8?B?Z0p5aHFmSWlzVC83K2VIb1FTaTY0aGxHaHdvdWdXamZ2Z05tY09XWlc2S2Nw?= =?utf-8?B?QTViaUh3NU5wK29SV1hJWFlQalNJVGJuQmZseWh2cWY0VnJaaHkvYmNocU0r?= =?utf-8?B?bUlnME5LRDVIeVdLMEpySWkrQ2xLUzJGclVHMmFBSmhvMS9uNGx2S2t5SXBj?= =?utf-8?B?UTB3MzJOUjd0SEdpaXc1cDlPY1hqMmFqb3djYldRTnJEWGZFVUtyTnUwZ084?= =?utf-8?B?WTBNTXZlbmFDdU8rbVk2Q01ibnN3Y2dZQWZzYUY0bUVpdUhNVE9QYlUwMGpp?= =?utf-8?B?WjdwT2RYaWhkZWRTYmZJVkY1QW1PdkRhWFNTbjQ3RytzcHppTk1YbFVCYWZq?= =?utf-8?B?RXZvbm1HdWYrZURQUUFITXhwei96Z2lPNWlhcjJWU09yQU94R3J3NXVWZy8z?= =?utf-8?B?bzd1NEpHMHJ4dksyZ0FyNk5nZTNUb1B3SXN2TU16Yzk4dWhCcXFZTVJXSGZl?= =?utf-8?B?Snk5em1mS1pTaGRIK1pEZHRSRzN2VkFpSkJsZXdHaGVSWFlDWSs5Y3pHUENT?= =?utf-8?B?Vm53ck9VY0x1TmpCQVpUVFFlLytYazFyc2VlbEluaEhEWFVjSThHeENDUjU2?= =?utf-8?B?MFJPVGxORkE1VUJkUjNCMEZ3bnlwWDc2eERaRnRac2o1bThaS2JPVnRvOVlG?= =?utf-8?B?ZDdNVWhkakF2UWtUbUhpZzFZR2hWempOOFgweDhUd0Y4bmJzZ3oxanpiYlcv?= =?utf-8?B?dmM5YUlXVmJuQkRzTVRYakhMY0NLa21ERmRpRHpuZUluYjlveHNXS2dtazVF?= =?utf-8?B?ZXNGaEFaNW1Xb3QxWnZUaVA3OU8vcXZIMEo2SmJlMFA3ZXNaSEJPOWhZTGpq?= =?utf-8?B?ZGJCbGZ2V09JdUZWMkQ5RkwrMTFEUlVWUEhjbnVmaS9oblE0RnVyYnVaMkZi?= =?utf-8?B?aDZodFFoY3YyOS9NQys0VTJiZWF5RmY1STE4bjJuREZjM05FWUlrUU9QanpH?= =?utf-8?B?aThtV0JHVlp2N0k3cGZWckUxNjRnRE5FOE8xSEZwVU1EOTJXMVpHMEd5d3Zk?= =?utf-8?Q?3+ZNrLnKlhvXLmpGzM?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: a66dac35-db97-4224-d3c5-08dedc93d48d X-MS-Exchange-CrossTenant-AuthSource: IA0PR12MB8374.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jul 2026 01:54:21.9365 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HZe2+8l00181bDBcifzmDta4KOVuOeDYgKy3qqs63DL2DlIAzYfuqHrUkLX6qiHX X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6290 On Tue Jul 7, 2026 at 8:39 PM EDT, Kefeng Wang wrote: > pte_pfn() and pte_dirty() have undefined behaviour when called on a > non-present PTE. In migrate_vma_collect_pmd(), these functions may be > invoked on non-present entries (e.g., device-private entries), leading > to potential crashes from pte_pfn() or incorrect dirty folio accounting > from pte_dirty(). Fix both by guarding with pte_present() checks. > > Fixes: fd35ca3d12cc ("mm/migrate_device.c: copy pte dirty bit to page") > Fixes: 6c287605fd56 ("mm: remember exclusively mapped anonymous pages wit= h PG_anon_exclusive") > Cc: > Signed-off-by: Kefeng Wang > --- > v2: > - correct changelog and Fixes tags, suggested by David. > - cc stable, suggested by Andrew. > > mm/migrate_device.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > Acked-by: Zi Yan --=20 Best Regards, Yan, Zi