Re: [PATCH] ASoC: ak4642: Enable cache usage to fix crashes on resume

Geert Uytterhoeven
2016-05-18T18:05:44Z

Hi Mark,

On Wed, May 18, 2016 at 7:49 PM, Mark Brown <broonie@kernel.org> wrote:
> The ak4642 driver is using a regmap cache sync to restore the
> configuration of the chip on resume but (as Peter observed) does not
> actually define a register cache which means that the resume is never
> going to work and we trigger asserts in regmap. Fix this by enabling
> caching.
>
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Reported-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> Signed-off-by: Mark Brown <broonie@kernel.org>
> Cc: stable@vger.kernel.org

Thanks, this gets rid of the

kernel BUG at drivers/base/regmap/regcache.c:347!

I was seeing.

Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds