From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03FF9C4361B for ; Wed, 9 Dec 2020 12:12:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BCE1D23B7B for ; Wed, 9 Dec 2020 12:12:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730424AbgLIMMY (ORCPT ); Wed, 9 Dec 2020 07:12:24 -0500 Received: from mail.kernel.org ([198.145.29.99]:34010 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731379AbgLIMMT (ORCPT ); Wed, 9 Dec 2020 07:12:19 -0500 Date: Wed, 9 Dec 2020 13:12:55 +0100 From: Greg KH To: Samuel Thibault , stable@vger.kernel.org Subject: Re: [PATCH for 4.14] speakup: Reject setting the speakup line discipline outside of speakup Message-ID: References: <20201209110722.7jpp7bk7p54hudnd@function> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201209110722.7jpp7bk7p54hudnd@function> Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, Dec 09, 2020 at 12:07:22PM +0100, Samuel Thibault wrote: > [backport of 5.10 commit f0992098cadb4c9c6a00703b66cafe604e178fea] > > Speakup exposing a line discipline allows userland to try to use it, > while it is deemed to be useless, and thus uselessly exposes potential > bugs. One of them is simply that in such a case if the line sends data, > spk_ttyio_receive_buf2 is called and crashes since spk_ttyio_synth > is NULL. > > This change restricts the use of the speakup line discipline to > speakup drivers, thus avoiding such kind of issues altogether. > > Cc: stable@vger.kernel.org > Reported-by: Shisong Qin > Signed-off-by: Samuel Thibault > Tested-by: Shisong Qin > Link: https://lore.kernel.org/r/20201129193523.hm3f6n5xrn6fiyyc@function > Signed-off-by: Greg Kroah-Hartman Both of these worked, thanks! greg k-h