From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6164C433FE for ; Sun, 16 Oct 2022 13:32:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229679AbiJPNcL (ORCPT ); Sun, 16 Oct 2022 09:32:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40480 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229600AbiJPNcK (ORCPT ); Sun, 16 Oct 2022 09:32:10 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8AE411F60B; Sun, 16 Oct 2022 06:32:09 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2984860B66; Sun, 16 Oct 2022 13:32:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5C0BEC433C1; Sun, 16 Oct 2022 13:32:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1665927128; bh=mvMBF0DOb6n13bDpC9zQpU7sToJw8MJ2EzOEAWLjFLQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VXYT9eSiyCMtqsEeMsyzluzRElbNZoS+cMo3cALPFvFrg3b72jWOZLuKECw2958n4 nS73o0X0Okvlv+oiECfl0bStoN0Nu4V9KM+vjep6dhAIVhy6JfkSOgt+9/ta3QHaAv JVFOOjgVwDVOsGf9CUe5lHAyszufWws4NqsORsWKOQj65E7m4VEEw/tx6kmHKRm0lm Zj34ZONPH7yzVFEwtS5sXlrOEXfrIxaWr16ai1JmCSkFVPJ70MKAsAwzaWtr5WSRrJ TjcomHPrDY7lfM0Yg3ngrAKwFO+RWGix/rBLBl5UjxFFEn+5eg0Y2SNhUkpSpMcOPW owomn8svoqZpQ== Date: Sun, 16 Oct 2022 09:32:07 -0400 From: Sasha Levin To: Greg Kroah-Hartman Cc: Joe Perches , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Michael Straube , Philipp Hortmann , Larry.Finger@lwfinger.net, phil@philpotter.co.uk, martin@kaiser.cx, paskripkin@gmail.com, gszymaszek@short.pl, fmdefrancesco@gmail.com, makvihas@gmail.com, saurav.girepunje@gmail.com, linux-staging@lists.linux.dev Subject: Re: [PATCH AUTOSEL 5.19 01/63] staging: r8188eu: do not spam the kernel log Message-ID: References: <20221013001842.1893243-1-sashal@kernel.org> <60af3294445ba2d2289a32ef7e429111ff476b44.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Thu, Oct 13, 2022 at 06:46:12AM +0200, Greg Kroah-Hartman wrote: >On Wed, Oct 12, 2022 at 08:08:58PM -0700, Joe Perches wrote: >> On Wed, 2022-10-12 at 20:17 -0400, Sasha Levin wrote: >> > From: Michael Straube >> > >> > [ Upstream commit 9a4d0d1c21b974454926c3b832b4728679d818eb ] >> > >> > Drivers should not spam the kernel log if they work properly. Convert >> > the functions Hal_EfuseParseIDCode88E() and _netdev_open() to use >> > netdev_dbg() instead of pr_info() so that developers can still enable >> > it if they want to see this information. >> >> Why should this be backported? > >I agree, Sasha please drop this from all branches. I'll drop it, but for the record: I've been picking up patches that help with log spam like any other regular fixes. Being on the receiving end of spammy kernel code and making debugging issues much harder, I think it's as important (if not more) than some other classes of fixes we pick up. -- Thanks, Sasha