[PATCH] ACPI: video: Force backlight native for more TongFang devices

[PATCH] ACPI: video: Force backlight native for more TongFang devices

[Werner Sembach]

commit 3dbc80a3e4c55c4a5b89ef207bed7b7de36157b4 upstream.

The upstream commit "ACPI: video: Make backlight class device registration
a separate step (v2)" changes the logic in a way that these quirks are not
required anymore, but kernel <= 6.0 still need these.

The TongFang GKxNRxx, GMxNGxx, GMxZGxx, and GMxRGxx / TUXEDO
Stellaris/Polaris Gen 1-4, have the same problem as the Clevo NL5xRU and
NL5xNU / TUXEDO Aura 15 Gen1 and Gen2:
They have a working native and video interface for screen backlight.
However the default detection mechanism first registers the video interface
before unregistering it again and switching to the native interface during
boot. This results in a dangling SBIOS request for backlight change for
some reason, causing the backlight to switch to ~2% once per boot on the
first power cord connect or disconnect event. Setting the native interface
explicitly circumvents this buggy behaviour by avoiding the unregistering
process.

Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
---
 drivers/acpi/video_detect.c | 64 +++++++++++++++++++++++++++++++++++++
 1 file changed, 64 insertions(+)

diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c
index 3b972ca53689..e5518b88f710 100644
--- a/drivers/acpi/video_detect.c
+++ b/drivers/acpi/video_detect.c
@@ -463,6 +463,70 @@ static const struct dmi_system_id video_detect_dmi_table[] = {
 		DMI_MATCH(DMI_BOARD_NAME, "PF5LUXG"),
 		},
 	},
+	/*
+	 * More Tongfang devices with the same issue as the Clevo NL5xRU and
+	 * NL5xNU/TUXEDO Aura 15 Gen1 and Gen2. See the description above.
+	 */
+	{
+	.callback = video_detect_force_native,
+	.ident = "TongFang GKxNRxx",
+	.matches = {
+		DMI_MATCH(DMI_BOARD_NAME, "GKxNRxx"),
+		},
+	},
+	{
+	.callback = video_detect_force_native,
+	.ident = "TongFang GKxNRxx",
+	.matches = {
+		DMI_MATCH(DMI_SYS_VENDOR, "TUXEDO"),
+		DMI_MATCH(DMI_BOARD_NAME, "POLARIS1501A1650TI"),
+		},
+	},
+	{
+	.callback = video_detect_force_native,
+	.ident = "TongFang GKxNRxx",
+	.matches = {
+		DMI_MATCH(DMI_SYS_VENDOR, "TUXEDO"),
+		DMI_MATCH(DMI_BOARD_NAME, "POLARIS1501A2060"),
+		},
+	},
+	{
+	.callback = video_detect_force_native,
+	.ident = "TongFang GKxNRxx",
+	.matches = {
+		DMI_MATCH(DMI_SYS_VENDOR, "TUXEDO"),
+		DMI_MATCH(DMI_BOARD_NAME, "POLARIS1701A1650TI"),
+		},
+	},
+	{
+	.callback = video_detect_force_native,
+	.ident = "TongFang GKxNRxx",
+	.matches = {
+		DMI_MATCH(DMI_SYS_VENDOR, "TUXEDO"),
+		DMI_MATCH(DMI_BOARD_NAME, "POLARIS1701A2060"),
+		},
+	},
+	{
+	.callback = video_detect_force_native,
+	.ident = "TongFang GMxNGxx",
+	.matches = {
+		DMI_MATCH(DMI_BOARD_NAME, "GMxNGxx"),
+		},
+	},
+	{
+	.callback = video_detect_force_native,
+	.ident = "TongFang GMxZGxx",
+	.matches = {
+		DMI_MATCH(DMI_BOARD_NAME, "GMxZGxx"),
+		},
+	},
+	{
+	.callback = video_detect_force_native,
+	.ident = "TongFang GMxRGxx",
+	.matches = {
+		DMI_MATCH(DMI_BOARD_NAME, "GMxRGxx"),
+		},
+	},
 	/*
 	 * Desktops which falsely report a backlight and which our heuristics
 	 * for this do not catch.
-- 
2.34.1

Re: [PATCH] ACPI: video: Force backlight native for more TongFang devices

[Greg KH]

On Wed, Oct 19, 2022 at 04:01:42PM +0200, Werner Sembach wrote:
> commit 3dbc80a3e4c55c4a5b89ef207bed7b7de36157b4 upstream.

That is not this commit at all :(

> The upstream commit "ACPI: video: Make backlight class device registration
> a separate step (v2)" changes the logic in a way that these quirks are not
> required anymore, but kernel <= 6.0 still need these.
> 
> The TongFang GKxNRxx, GMxNGxx, GMxZGxx, and GMxRGxx / TUXEDO
> Stellaris/Polaris Gen 1-4, have the same problem as the Clevo NL5xRU and
> NL5xNU / TUXEDO Aura 15 Gen1 and Gen2:
> They have a working native and video interface for screen backlight.
> However the default detection mechanism first registers the video interface
> before unregistering it again and switching to the native interface during
> boot. This results in a dangling SBIOS request for backlight change for
> some reason, causing the backlight to switch to ~2% once per boot on the
> first power cord connect or disconnect event. Setting the native interface
> explicitly circumvents this buggy behaviour by avoiding the unregistering
> process.
> 
> Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
> ---
>  drivers/acpi/video_detect.c | 64 +++++++++++++++++++++++++++++++++++++
>  1 file changed, 64 insertions(+)
> 


<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read:
    https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

</formletter>

Re: [PATCH] ACPI: video: Force backlight native for more TongFang devices

[Werner Sembach]

Am 19.10.22 um 16:57 schrieb Greg KH:

> On Wed, Oct 19, 2022 at 04:01:42PM +0200, Werner Sembach wrote:
>> commit 3dbc80a3e4c55c4a5b89ef207bed7b7de36157b4 upstream.
> That is not this commit at all :(

Yes, that commit is obsoleting these quirks. I think I misinterpreted 
the doc. I thought some kind of upstream commit has to be always 
included. Now reading it again, I should have just left that line out?

What I wanted to say: These quirks are not required on upstream, but 
only on <= 6.0.y

I'm sorry for causing confusion (again q.q)

>
>> The upstream commit "ACPI: video: Make backlight class device registration
>> a separate step (v2)" changes the logic in a way that these quirks are not
>> required anymore, but kernel <= 6.0 still need these.
>>
>> The TongFang GKxNRxx, GMxNGxx, GMxZGxx, and GMxRGxx / TUXEDO
>> Stellaris/Polaris Gen 1-4, have the same problem as the Clevo NL5xRU and
>> NL5xNU / TUXEDO Aura 15 Gen1 and Gen2:
>> They have a working native and video interface for screen backlight.
>> However the default detection mechanism first registers the video interface
>> before unregistering it again and switching to the native interface during
>> boot. This results in a dangling SBIOS request for backlight change for
>> some reason, causing the backlight to switch to ~2% once per boot on the
>> first power cord connect or disconnect event. Setting the native interface
>> explicitly circumvents this buggy behaviour by avoiding the unregistering
>> process.
>>
>> Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
>> ---
>>   drivers/acpi/video_detect.c | 64 +++++++++++++++++++++++++++++++++++++
>>   1 file changed, 64 insertions(+)
>>
>
> <formletter>
>
> This is not the correct way to submit patches for inclusion in the
> stable kernel tree.  Please read:
>      https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
> for how to do this properly.
>
> </formletter>

Re: [PATCH] ACPI: video: Force backlight native for more TongFang devices

[Werner Sembach]

Am 19.10.22 um 17:18 schrieb Werner Sembach:
> Am 19.10.22 um 16:57 schrieb Greg KH:
>
>> On Wed, Oct 19, 2022 at 04:01:42PM +0200, Werner Sembach wrote:
>>> commit 3dbc80a3e4c55c4a5b89ef207bed7b7de36157b4 upstream.
>> That is not this commit at all :(
>
> Yes, that commit is obsoleting these quirks. I think I misinterpreted 
> the doc. I thought some kind of upstream commit has to be always 
> included. Now reading it again, I should have just left that line out?
>
> What I wanted to say: These quirks are not required on upstream, but 
> only on <= 6.0.y
>
> I'm sorry for causing confusion (again q.q)
Sent again as v2, hopefully correct his time.
>
>>
>>> The upstream commit "ACPI: video: Make backlight class device 
>>> registration
>>> a separate step (v2)" changes the logic in a way that these quirks 
>>> are not
>>> required anymore, but kernel <= 6.0 still need these.
>>>
>>> The TongFang GKxNRxx, GMxNGxx, GMxZGxx, and GMxRGxx / TUXEDO
>>> Stellaris/Polaris Gen 1-4, have the same problem as the Clevo NL5xRU 
>>> and
>>> NL5xNU / TUXEDO Aura 15 Gen1 and Gen2:
>>> They have a working native and video interface for screen backlight.
>>> However the default detection mechanism first registers the video 
>>> interface
>>> before unregistering it again and switching to the native interface 
>>> during
>>> boot. This results in a dangling SBIOS request for backlight change for
>>> some reason, causing the backlight to switch to ~2% once per boot on 
>>> the
>>> first power cord connect or disconnect event. Setting the native 
>>> interface
>>> explicitly circumvents this buggy behaviour by avoiding the 
>>> unregistering
>>> process.
>>>
>>> Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
>>> ---
>>>   drivers/acpi/video_detect.c | 64 
>>> +++++++++++++++++++++++++++++++++++++
>>>   1 file changed, 64 insertions(+)
>>>
>>
>> <formletter>
>>
>> This is not the correct way to submit patches for inclusion in the
>> stable kernel tree.  Please read:
>> https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
>> for how to do this properly.
>>
>> </formletter>