Re: [PATCH 1/2] Revert "drm/amdgpu: move nbio sdma_doorbell_range() into sdma code for vega"

[Salvatore Bonaccorso <carnil@debian.org>]

Hi,

On Fri, Oct 21, 2022 at 02:29:22AM +0200, Diederik de Haas wrote:
> On Thursday, 20 October 2022 17:38:56 CEST Alex Deucher wrote:
> > This reverts commit 9f55f36f749a7608eeef57d7d72991a9bd557341.
> > 
> > This patch was backported incorrectly when Sasha backported it and
> > the patch that caused the regression that this patch set fixed
> > was reverted in commit 412b844143e3 ("Revert "PCI/portdrv: Don't disable AER
> > reporting in get_port_device_capability()""). This isn't necessary and
> > causes a regression so drop it.
> > 
> > Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/2216
> > Cc: Shuah Khan <skhan@linuxfoundation.org>
> > Cc: Sasha Levin <sashal@kernel.org>
> > Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> > Cc: <stable@vger.kernel.org>    # 5.10
> > ---
> 
> I build a kernel with these 2 patches reverted and can confirm that that fixes 
> the issue on my machine with a Radeon RX Vega 64 GPU. 
> # lspci -nn | grep VGA
> 0b:00.0 VGA compatible controller [0300]: Advanced Micro Devices, Inc. [AMD/
> ATI] Vega 10 XL/XT [Radeon RX Vega 56/64] [1002:687f] (rev c1)
> 
> So feel free to add
> 
> Tested-By: Diederik de Haas <didi.debian@cknow.org>

Note additionally (probably only relevant for Greg while reviewing),
that the first of the commits which need to be reverted is already
queued as revert in queue-5.10.

Regards,
Salvatore