Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: Dominique Martinet <dominique.martinet@atmark-techno.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Lukas Wunner" <lukas@wunner.de>,
	stable@vger.kernel.org,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	"Matthias Schiffer" <matthias.schiffer@ew.tq-group.com>,
	"Roosen Henri" <Henri.Roosen@ginzinger.com>,
	linux-serial@vger.kernel.org,
	"Lino Sanfilippo" <LinoSanfilippo@gmx.de>,
	"Daisuke Mizobuchi" <mizo@atmark-techno.com>
Subject: Re: [PATCH 5.10 v2 1/2] serial: core: move RS485 configuration tasks from drivers into core
Date: Thu, 27 Oct 2022 09:21:41 +0900	[thread overview]
Message-ID: <Y1nPFe6IaRI7j6fE@atmark-techno.com> (raw)
In-Reply-To: <Y1lmM7Qu1yscuaIU@kroah.com>

Greg Kroah-Hartman wrote on Wed, Oct 26, 2022 at 06:54:11PM +0200:
> On Mon, Oct 17, 2022 at 02:17:36PM +0900, Dominique Martinet wrote:
> > From: Lino Sanfilippo <LinoSanfilippo@gmx.de>
> > 
> > Several drivers that support setting the RS485 configuration via userspace
> > implement one or more of the following tasks:
> > 
> > - in case of an invalid RTS configuration (both RTS after send and RTS on
> >   send set or both unset) fall back to enable RTS on send and disable RTS
> >   after send
> > 
> > - nullify the padding field of the returned serial_rs485 struct
> > 
> > - copy the configuration into the uart port struct
> > 
> > - limit RTS delays to 100 ms
> > 
> > Move these tasks into the serial core to make them generic and to provide
> > a consistent behaviour among all drivers.
> > 
> > Signed-off-by: Lino Sanfilippo <LinoSanfilippo@gmx.de>
> > Link: https://lore.kernel.org/r/20220410104642.32195-2-LinoSanfilippo@gmx.de
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > [ Upstream commit 0ed12afa5655512ee418047fb3546d229df20aa1 ]
> > Signed-off-by: Daisuke Mizobuchi <mizo@atmark-techno.com>
> > Signed-off-by: Dominique Martinet <dominique.martinet@atmark-techno.com>
> > ---
> > Follow-up of https://lkml.kernel.org/r/20221017013807.34614-1-dominique.martinet@atmark-techno.com
> 
> I need a 5.15.y version of this series before I can take the 5.10.y
> version.

Thanks for the probing, I did not know about this rule (but it makes
sense); I've just sent a 5.15 version:
https://lkml.kernel.org/r/20221027001943.637449-1-dominique.martinet@atmark-techno.com

I'd really appreciate if Lino could take a look and confirm we didn't
botch this too much -- we've tested the 5.10 version and it looks ok,
but this is different enough from the original patch to warrant a check
from the author.

Thanks!
-- 
Dominique



  reply	other threads:[~2022-10-27  0:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-17  5:17 [PATCH 5.10 v2 1/2] serial: core: move RS485 configuration tasks from drivers into core Dominique Martinet
2022-10-17  5:17 ` [PATCH 5.10 v2 2/2] serial: Deassert Transmit Enable on probe in driver-specific way Dominique Martinet
2022-10-26 16:54 ` [PATCH 5.10 v2 1/2] serial: core: move RS485 configuration tasks from drivers into core Greg Kroah-Hartman
2022-10-27  0:21   ` Dominique Martinet [this message]
2022-10-27 10:24     ` Greg Kroah-Hartman
2022-10-28  8:06     ` Lino Sanfilippo
2022-10-29  6:58       ` Dominique Martinet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y1nPFe6IaRI7j6fE@atmark-techno.com \
    --to=dominique.martinet@atmark-techno.com \
    --cc=Henri.Roosen@ginzinger.com \
    --cc=LinoSanfilippo@gmx.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-serial@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=matthias.schiffer@ew.tq-group.com \
    --cc=mizo@atmark-techno.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox