public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jiri Olsa <olsajiri@gmail.com>
Cc: Dominique Martinet <asmadeus@codewreck.org>,
	stable@vger.kernel.org,
	Martin Rodriguez Reboredo <yakoyoku@gmail.com>,
	Andrii Nakryiko <andrii@kernel.org>
Subject: Re: [PATCH 5.10] kbuild: fix BTF build with pahole 1.24
Date: Thu, 27 Oct 2022 17:02:14 +0200	[thread overview]
Message-ID: <Y1qddouJLYV0wlNw@kroah.com> (raw)
In-Reply-To: <Y1qAh6TzBw4b3+TQ@krava>

On Thu, Oct 27, 2022 at 02:58:47PM +0200, Jiri Olsa wrote:
> On Thu, Oct 27, 2022 at 09:01:58PM +0900, Dominique Martinet wrote:
> > pahole 1.24 broke builds on kernel <6.0 which do not have the
> > new BTF_KIND_ENUM64 BTF tag.
> > The 5.15 branch fixed this in commit b775fbf532dc01ae53a6fc56168fd30cb4b0c658
> > ("kbuild: Add skip_encoding_btf_enum64 option to pahole"), which
> > we cannot use directly for 5.10 because 5.10 does not have the
> > pahole-flags.sh script, itself introduced in upstream commit
> > 0baced0e0938f2895ceba54038eaf15ed91032e7 ("kbuild: Unify options
> > for BTF generation for vmlinux and modules")
> > 
> > that last commit is difficult to backport as 5.10 does not have BTF
> > for modules support: work around the problem by just copying the
> > pahole-flags.sh script and calling it directly in link-vmlinux.sh,
> > which is hopefully acceptable as the flags are not shared in this tree.
> > 
> > Note that compared to 5.15 the flags script does not have
> > --btf_gen_floats as linux 5.10 did not have that BTF tag yet;
> > but any new flag added to 5.15 will not be able to be added to 5.10 in
> > an identical way for any future breakage.
> > 
> > Cc: Martin Rodriguez Reboredo <yakoyoku@gmail.com>
> > Cc: Jiri Olsa <jolsa@kernel.org>
> > CC: Andrii Nakryiko <andrii@kernel.org>
> > Signed-off-by: Dominique Martinet <asmadeus@codewreck.org>
> 
> hi,
> I sent this backport just recently:
>   https://lore.kernel.org/bpf/Y1lkASXgeW0jfP8o@kroah.com/T/#t
> 
> it's split into several patches, hopefuly fixing the issue for you

Yes, this should be resolved in the next 5.10.y release.

thanks,

greg k-h

  reply	other threads:[~2022-10-27 15:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-27 12:01 [PATCH 5.10] kbuild: fix BTF build with pahole 1.24 Dominique Martinet
2022-10-27 12:58 ` Jiri Olsa
2022-10-27 15:02   ` Greg Kroah-Hartman [this message]
2022-10-27 21:56   ` Dominique Martinet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y1qddouJLYV0wlNw@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=andrii@kernel.org \
    --cc=asmadeus@codewreck.org \
    --cc=olsajiri@gmail.com \
    --cc=stable@vger.kernel.org \
    --cc=yakoyoku@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox