* [PATCH AUTOSEL 4.9] rtc: cmos: fix build on non-ACPI platforms
@ 2022-11-06 17:07 Sasha Levin
2022-11-06 17:54 ` Alexandre Belloni
0 siblings, 1 reply; 2+ messages in thread
From: Sasha Levin @ 2022-11-06 17:07 UTC (permalink / raw)
To: linux-kernel, stable
Cc: Alexandre Belloni, kernel test robot, Sasha Levin, a.zummo,
linux-rtc
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
[ Upstream commit db4e955ae333567dea02822624106c0b96a2f84f ]
Now that rtc_wake_setup is called outside of cmos_wake_setup, it also need
to be defined on non-ACPI platforms.
Reported-by: kernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/r/20221018203512.2532407-1-alexandre.belloni@bootlin.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
drivers/rtc/rtc-cmos.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/rtc/rtc-cmos.c b/drivers/rtc/rtc-cmos.c
index 1dbd8419df7d..2c3881bdf9bb 100644
--- a/drivers/rtc/rtc-cmos.c
+++ b/drivers/rtc/rtc-cmos.c
@@ -1113,6 +1113,9 @@ static void cmos_check_acpi_rtc_status(struct device *dev,
{
}
+static void rtc_wake_setup(struct device *dev)
+{
+}
#endif
#ifdef CONFIG_PNP
--
2.35.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH AUTOSEL 4.9] rtc: cmos: fix build on non-ACPI platforms
2022-11-06 17:07 [PATCH AUTOSEL 4.9] rtc: cmos: fix build on non-ACPI platforms Sasha Levin
@ 2022-11-06 17:54 ` Alexandre Belloni
0 siblings, 0 replies; 2+ messages in thread
From: Alexandre Belloni @ 2022-11-06 17:54 UTC (permalink / raw)
To: Sasha Levin; +Cc: linux-kernel, stable, kernel test robot, a.zummo, linux-rtc
Hello, this doesn't need to be backported unless you also backport
those:
0782b66ed2fb rtc: cmos: Fix wake alarm breakage
4919d3eb2ec0 rtc: cmos: Fix event handler registration ordering issue
6492fed7d8c9 rtc: rtc-cmos: Do not check ACPI_FADT_LOW_POWER_S0
On 06/11/2022 12:07:29-0500, Sasha Levin wrote:
> From: Alexandre Belloni <alexandre.belloni@bootlin.com>
>
> [ Upstream commit db4e955ae333567dea02822624106c0b96a2f84f ]
>
> Now that rtc_wake_setup is called outside of cmos_wake_setup, it also need
> to be defined on non-ACPI platforms.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Link: https://lore.kernel.org/r/20221018203512.2532407-1-alexandre.belloni@bootlin.com
> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> Signed-off-by: Sasha Levin <sashal@kernel.org>
> ---
> drivers/rtc/rtc-cmos.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/rtc/rtc-cmos.c b/drivers/rtc/rtc-cmos.c
> index 1dbd8419df7d..2c3881bdf9bb 100644
> --- a/drivers/rtc/rtc-cmos.c
> +++ b/drivers/rtc/rtc-cmos.c
> @@ -1113,6 +1113,9 @@ static void cmos_check_acpi_rtc_status(struct device *dev,
> {
> }
>
> +static void rtc_wake_setup(struct device *dev)
> +{
> +}
> #endif
>
> #ifdef CONFIG_PNP
> --
> 2.35.1
>
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-06 17:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-06 17:07 [PATCH AUTOSEL 4.9] rtc: cmos: fix build on non-ACPI platforms Sasha Levin
2022-11-06 17:54 ` Alexandre Belloni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).