From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 896A5C4332F for ; Wed, 9 Nov 2022 15:06:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229942AbiKIPGh (ORCPT ); Wed, 9 Nov 2022 10:06:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42882 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231838AbiKIPGg (ORCPT ); Wed, 9 Nov 2022 10:06:36 -0500 Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 317781A813 for ; Wed, 9 Nov 2022 07:06:36 -0800 (PST) Received: by mail-pj1-x1035.google.com with SMTP id gw22so16975257pjb.3 for ; Wed, 09 Nov 2022 07:06:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=wHPhbbvw5zFQKI19I4sRlCQw5xxCQ/IYVwUpkVORIms=; b=R/SWCxd+3hQJIoJnDxrsqdA56lLB5g+FgnJMOYd8l4iyIq96g+qxIwYGU0X8opCQfd qTl67qlRX1cM4loGOVfON0qjK65rCHwemp7HPP7+J3JSi9QhlC23IwXQQXU33QhIAQsu 7SBqJGvSM4zIjGUjq/KemmRWQ9r8ojzN2AN3UG6ulpQ9oZPgWEsqjmvOogAN+WkgljqQ eA/75xbxirqNB0iWC7CkaU+25AloDkSx+G24wbQbVj2ycJ3Ea9ljz1bIFzj15pboP0fn So2czgfaa9+daUHBRcqu1U04LAR2sIG6io3ydzlVeHN1n/uBOtNyNcPSVCBzCPdjNtgY 5HAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wHPhbbvw5zFQKI19I4sRlCQw5xxCQ/IYVwUpkVORIms=; b=mIWBGX+4PuUBeF8Gg/j25hPerGH3Fwc1Ln0+Zdw+NpJIYEeCCxtLRYEKmM22XnVUT5 h3+7PMvbkZt3DTlbCsgsko83CP+WacNujxOew017iUPas5mIVDZpFgxypIV0U41r0p1j U4UWtEIKYMb2O71OPugHPb9gvYj9/S+CUVtNIcrqNEO4cfj3/KlCl7fkgm4WDLUU1hnp xL0m9DIgYUIWl46Z3rv159enbITPHPXPhV+/kl1ArlH8LtbDlrJ+ydJqwb5ZLyewpv7D MZeMAjKHfrvG/jbazbBer/ux9ZYszCWekumYHyBMoM0yMG6SbH6gSV1JyBDhclavVsD+ ln1A== X-Gm-Message-State: ACrzQf0oCYVT0wEYv830t07+R/z8/qibbj/yvKmg7h8rBBS281kYpQhs 7jm9isrFVtJu+8YY+VheN9JNsA== X-Google-Smtp-Source: AMsMyM6Z5xLVh5jZzjJlzADewH2T5jsFGuZx0MlXhl+qVr1AAl9XYi1PgOdRS78kxn+PpGeJKUGNKg== X-Received: by 2002:a17:90b:1d8a:b0:213:cdfa:8aa2 with SMTP id pf10-20020a17090b1d8a00b00213cdfa8aa2mr55457865pjb.204.1668006395438; Wed, 09 Nov 2022 07:06:35 -0800 (PST) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id j12-20020a170902da8c00b0017f5ad327casm9224672plx.103.2022.11.09.07.06.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Nov 2022 07:06:35 -0800 (PST) Date: Wed, 9 Nov 2022 15:06:31 +0000 From: Sean Christopherson To: Paolo Bonzini Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, thomas.lendacky@amd.com, jmattson@google.com, stable@vger.kernel.org Subject: Re: [PATCH 01/11] KVM: x86: use a separate asm-offsets.c file Message-ID: References: <20221109145156.84714-1-pbonzini@redhat.com> <20221109145156.84714-2-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221109145156.84714-2-pbonzini@redhat.com> Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, Nov 09, 2022, Paolo Bonzini wrote: > This already removes the ugly #includes from asm-offsets.c, but especially > it avoids a future error when asm-offsets will try to include svm/svm.h. > > This would not work for kernel/asm-offsets.c, because svm/svm.h > includes kvm_cache_regs.h which is not in the include path when > compiling asm-offsets.c. The problem is not there if the .c file is > in arch/x86/kvm. > > Suggested-by: Sean Christopherson > Cc: stable@vger.kernel.org > Fixes: a149180fbcf3 ("x86: Add magic AMD return-thunk") > Signed-off-by: Paolo Bonzini > --- Reviewed-by: Sean Christopherson > diff --git a/arch/x86/kvm/vmx/vmenter.S b/arch/x86/kvm/vmx/vmenter.S > index 8477d8bdd69c..0b5db4de4d09 100644 > --- a/arch/x86/kvm/vmx/vmenter.S > +++ b/arch/x86/kvm/vmx/vmenter.S > @@ -1,12 +1,12 @@ > /* SPDX-License-Identifier: GPL-2.0 */ > #include > #include > -#include > #include > #include > #include > #include > #include > +#include "kvm-asm-offsets.h" Do you have a preference on KVM files using dashes or underscores? Outside of kvm-x86-ops.h and kvm-x86-pmu-ops.h, KVM x86 uses underscores. I actually prefer dashes because they're slightly easier to type, but when there are only a few outliers I constantly mistype the names. If dashes are generally, maybe we could gradually/opportunistically move in that direction?