From: Greg KH <gregkh@linuxfoundation.org>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: stable@vger.kernel.org
Subject: Re: [PATCH 5.15 1/3] bitops: always define asm-generic non-atomic bitops
Date: Tue, 15 Nov 2022 18:07:27 +0100 [thread overview]
Message-ID: <Y3PHTy85wVcsWoUF@kroah.com> (raw)
In-Reply-To: <alpine.LRH.2.21.2211151139030.32285@file01.intranet.prod.int.rdu2.redhat.com>
On Tue, Nov 15, 2022 at 11:42:55AM -0500, Mikulas Patocka wrote:
> commit 21bb8af513d35c005c401706030f4eb469538d1d upstream.
>
> Move generic non-atomic bitops from the asm-generic header which
> gets included only when there are no architecture-specific
> alternatives, to a separate independent file to make them always
> available.
> Almost no actual code changes, only one comment added to
> generic_test_bit() saying that it's an atomic operation itself
> and thus `volatile` must always stay there with no cast-aways.
>
> Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> # comment
> Suggested-by: Marco Elver <elver@google.com> # reference to kernel-doc
> Signed-off-by: Alexander Lobakin <alexandr.lobakin@intel.com>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Reviewed-by: Marco Elver <elver@google.com>
> Signed-off-by: Yury Norov <yury.norov@gmail.com>
>
> ---
> include/asm-generic/bitops/generic-non-atomic.h | 130 ++++++++++++++++++++++++
> include/asm-generic/bitops/non-atomic.h | 110 +-------------------
> 2 files changed, 138 insertions(+), 102 deletions(-)
>
{sigh}
Please work with a kernel developer at your company that understands how
to send out patch series properly (correctly threaded and versioned),
and also go and read the DCO for what you need to do when sending on
patches that you want submitted (hint, you have to sign off on it.)
Then get THEM to also sign off on the contribution as well, showing that
they agree this change is needed, and is correct, and THEN resend all of
these, with the proper people copied also, in the correct format.
And properly use a 0/X email that explains why these changes are needed,
and what is involved with them, as I have no context at all (remember,
we deal with hundreds of changes a day.)
As it is, I can not take these patches at all, sorry, nor should you
want me to.
greg k-h
prev parent reply other threads:[~2022-11-15 17:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-15 16:42 [PATCH 5.15 1/3] bitops: always define asm-generic non-atomic bitops Mikulas Patocka
2022-11-15 17:07 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3PHTy85wVcsWoUF@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=mpatocka@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox